Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2765023002: [Android] Upstreaming notification channels part 2: Clean up (Closed)

Created:
3 years, 9 months ago by awdf
Modified:
3 years, 9 months ago
CC:
chromium-reviews, asanka, awdf+watch_chromium.org, ntp-dev+reviews_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, feature-media-reviews_chromium.org, noyau+watch_chromium.org, agrieve+watch_chromium.org, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Upstreaming notification channels part 2: Clean up The AppHooks method is removed since it is no longer used. Constants are renamed to refer to channels instead of categories, to match the Android APIs. BUG=702626 Review-Url: https://codereview.chromium.org/2765023002 Cr-Commit-Position: refs/heads/master@{#459582} Committed: https://chromium.googlesource.com/chromium/src/+/0c5ada71f25ba9b76a635f4be3cbd08ac0b007ce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -46 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java View 3 chunks +0 lines, -22 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationManager.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/MediaCaptureNotificationService.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderForO.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBroadcastService.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
awdf
peter - please review this also
3 years, 9 months ago (2017-03-22 15:00:08 UTC) #4
Peter Beverloo
lgtm. Do note that both Chromium patches have to land before the internal one.
3 years, 9 months ago (2017-03-22 15:10:33 UTC) #5
awdf
On 2017/03/22 15:10:33, Peter Beverloo wrote: > lgtm. Do note that both Chromium patches have ...
3 years, 9 months ago (2017-03-22 16:15:03 UTC) #6
awdf
+nyquist@ for owners review
3 years, 9 months ago (2017-03-22 18:28:51 UTC) #8
nyquist
lgtm
3 years, 9 months ago (2017-03-22 23:17:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2765023002/1
3 years, 9 months ago (2017-03-24 21:44:43 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 22:44:01 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0c5ada71f25ba9b76a635f4be3cb...

Powered by Google App Engine
This is Rietveld 408576698