chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBroadcastService.java - Issue 2765003002: [Android O] Upstreaming notification channels code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBroadcastService.java

Issue 2765003002: [Android O] Upstreaming notification channels code (Closed)

Patch Set: Rebase + update tag Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBroadcastService.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBroadcastService.java b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBroadcastService.java

index 1d88903efd8b2663ee50dd014c25115e47fec4d5..d267ba557cababce685a1727a5f77d082b206c2b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBroadcastService.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBroadcastService.java

@@ -20,8 +20,8 @@ import android.os.IBinder;

import org.chromium.base.ContextUtils;

import org.chromium.base.Log;

import org.chromium.chrome.R;

-import org.chromium.chrome.browser.AppHooks;

import org.chromium.chrome.browser.notifications.ChromeNotificationBuilder;

+import org.chromium.chrome.browser.notifications.NotificationBuilderFactory;

import org.chromium.chrome.browser.notifications.NotificationConstants;

import org.chromium.chrome.browser.notifications.NotificationManagerProxy;

import org.chromium.chrome.browser.notifications.NotificationManagerProxyImpl;

@@ -149,7 +149,7 @@ public class PhysicalWebBroadcastService extends Service {

NotificationManagerProxy notificationManager = new NotificationManagerProxyImpl(

(NotificationManager) getSystemService(NOTIFICATION_SERVICE));

ChromeNotificationBuilder notificationBuilder =

- AppHooks.get()

+ NotificationBuilderFactory

.createChromeNotificationBuilder(true /* preferCompat */,

NotificationConstants.CATEGORY_ID_BROWSER,

context.getString(R.string.notification_category_browser),