chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java - Issue 2765003002: [Android O] Upstreaming notification channels code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java

Issue 2765003002: [Android O] Upstreaming notification channels code (Closed)

Patch Set: Rebase + update tag Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBroadcastService.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java

index 0ce1c17e5dbda5b05b319a397d3f35f0ba7cfa63..07c2db4564d2fcf84085e1e25b22b1a67747870b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java

@@ -21,11 +21,11 @@ import org.chromium.base.annotations.CalledByNative;

import org.chromium.base.annotations.JNINamespace;

import org.chromium.base.library_loader.LibraryLoader;

import org.chromium.chrome.R;

-import org.chromium.chrome.browser.AppHooks;

import org.chromium.chrome.browser.IntentHandler;

import org.chromium.chrome.browser.ShortcutHelper;

import org.chromium.chrome.browser.document.ChromeLauncherActivity;

import org.chromium.chrome.browser.notifications.ChromeNotificationBuilder;

+import org.chromium.chrome.browser.notifications.NotificationBuilderFactory;

import org.chromium.chrome.browser.notifications.NotificationConstants;

import org.chromium.chrome.browser.notifications.NotificationUmaTracker;

import org.chromium.chrome.browser.ntp.snippets.ContentSuggestionsNotificationAction;

@@ -151,7 +151,7 @@ public class ContentSuggestionsNotificationHelper {

.putExtra(NOTIFICATION_CATEGORY_EXTRA, category)

.putExtra(NOTIFICATION_ID_WITHIN_CATEGORY_EXTRA, idWithinCategory);

ChromeNotificationBuilder builder =

- AppHooks.get()

+ NotificationBuilderFactory

.createChromeNotificationBuilder(true /* preferCompat */,

NotificationConstants.CATEGORY_ID_BROWSER,

context.getString(R.string.notification_category_browser),