Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2764943003: Attempt to de-flake popup blocker test for PlzNavigate (Closed)

Created:
3 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 9 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Attempt to de-flake popup blocker test for PlzNavigate BUG=663333 R=jam@chromium.org Review-Url: https://codereview.chromium.org/2764943003 Cr-Commit-Position: refs/heads/master@{#458686} Committed: https://chromium.googlesource.com/chromium/src/+/2dfb2037ddbed4665f325fa0858e76ae83418415

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc View 1 chunk +8 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
jochen (gone - plz use gerrit)
ptal. The test became flaky with --enable-browser-side-navigation, but not flaky enough to effectively debug this. ...
3 years, 9 months ago (2017-03-21 21:19:01 UTC) #3
jam
lgtm
3 years, 9 months ago (2017-03-22 00:01:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764943003/1
3 years, 9 months ago (2017-03-22 08:26:00 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 08:30:25 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2dfb2037ddbed4665f325fa0858e...

Powered by Google App Engine
This is Rietveld 408576698