Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: build/android/resource_sizes.py

Issue 2764913002: Add optional --no-static-initializer-check to resource_sizes.py (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/resource_sizes.py
diff --git a/build/android/resource_sizes.py b/build/android/resource_sizes.py
index ce0d6de6c67b0927cac213aa9a6123fde171b82a..41465061ec075ae634f9a2f2662d80616964888c 100755
--- a/build/android/resource_sizes.py
+++ b/build/android/resource_sizes.py
@@ -736,6 +736,8 @@ def main():
argparser.add_argument('--no-output-dir', action='store_true',
help='Skip all measurements that rely on having '
'output-dir')
+ argparser.add_argument('--no-static-initializer-check', action='store_true',
+ help='Skip checking for static initializers')
argparser.add_argument('-d', '--device',
help='Dummy option for perf runner.')
argparser.add_argument('--estimate-patch-size', action='store_true',
@@ -772,8 +774,9 @@ def main():
args.apk, args.builder, args.bucket, chartjson=chartjson)
if not args.no_output_dir:
PrintPakAnalysis(args.apk, args.min_pak_resource_size)
- _PrintStaticInitializersCountFromApk(
- args.apk, tools_prefix, chartjson=chartjson)
+ if not args.no_static_initializer_check:
jbudorick 2017/03/22 15:59:36 nit: this may be easier to read if the variable is
agrieve 2017/03/23 14:43:23 Done.
+ _PrintStaticInitializersCountFromApk(
+ args.apk, tools_prefix, chartjson=chartjson)
if chartjson:
results_path = os.path.join(args.output_dir, 'results-chart.json')
logging.critical('Dumping json to %s', results_path)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698