Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2764903002: Disable delete button if selected node is not associated with any cookie object (Closed)

Created:
3 years, 9 months ago by kdzwinel
Modified:
3 years, 9 months ago
Reviewers:
lushnikov, luoe, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Disable delete button if selected node is not associated with any cookie object Now it works like this: http://i.imgur.com/bVLesi7.gif BUG=694759 Review-Url: https://codereview.chromium.org/2764903002 Cr-Commit-Position: refs/heads/master@{#458863} Committed: https://chromium.googlesource.com/chromium/src/+/1a4a8261d05a2700334f969dae54dbdce05002c3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
kdzwinel
PTAL
3 years, 9 months ago (2017-03-21 13:04:38 UTC) #3
luoe
Thanks for taking this on! lgtm, it mirrors L107. It still needs a review from ...
3 years, 9 months ago (2017-03-22 18:07:57 UTC) #6
pfeldman
lgtm
3 years, 9 months ago (2017-03-22 18:14:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764903002/1
3 years, 9 months ago (2017-03-22 19:04:24 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 20:41:33 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1a4a8261d05a2700334f969dae54...

Powered by Google App Engine
This is Rietveld 408576698