Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Unified Diff: ui/gl/gl_surface_format_unittest.cc

Issue 2764853002: gl: Remove redundant methods/variables from GLSurfaceFormat (Closed)
Patch Set: Replaced format.IsDefault() check with format.IsCompatible(GLSurfaceFormat()) Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gl/gl_surface_format.cc ('k') | ui/gl/init/gl_factory_ozone.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gl/gl_surface_format_unittest.cc
diff --git a/ui/gl/gl_surface_format_unittest.cc b/ui/gl/gl_surface_format_unittest.cc
index 6e145c6267c37223f0c52d2edec61afb7198a397..119f218c1e9768b8e2380aa8c13ea1620701bf41 100644
--- a/ui/gl/gl_surface_format_unittest.cc
+++ b/ui/gl/gl_surface_format_unittest.cc
@@ -11,9 +11,7 @@ TEST(GLSurfaceFormatTest, BasicTest) {
{
// Check default format properties.
GLSurfaceFormat format = GLSurfaceFormat();
- EXPECT_TRUE(format.IsDefault());
EXPECT_EQ(32, format.GetBufferSize());
- EXPECT_FALSE(format.IsSurfaceless());
EXPECT_EQ(GLSurfaceFormat::PIXEL_LAYOUT_DONT_CARE,
format.GetPixelLayout());
}
@@ -22,23 +20,13 @@ TEST(GLSurfaceFormatTest, BasicTest) {
// Check rgb565 format as used for low-end Android devices.
GLSurfaceFormat format = GLSurfaceFormat();
format.SetRGB565();
- EXPECT_FALSE(format.IsDefault());
EXPECT_EQ(16, format.GetBufferSize());
}
{
- // Check surfaceless format.
- GLSurfaceFormat format = GLSurfaceFormat();
- format.SetIsSurfaceless();
- EXPECT_FALSE(format.IsDefault());
- EXPECT_TRUE(format.IsSurfaceless());
- }
-
- {
// Check custom pixel layout.
GLSurfaceFormat format = GLSurfaceFormat(
GLSurfaceFormat::PIXEL_LAYOUT_RGBA);
- EXPECT_FALSE(format.IsDefault());
EXPECT_EQ(GLSurfaceFormat::PIXEL_LAYOUT_RGBA,
format.GetPixelLayout());
« no previous file with comments | « ui/gl/gl_surface_format.cc ('k') | ui/gl/init/gl_factory_ozone.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698