Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2764843002: Hangup call in WebRtcAudioDebugRecordingsBrowserTest. (Closed)

Created:
3 years, 9 months ago by Henrik Grunell
Modified:
3 years, 9 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Hangup call in WebRtcAudioDebugRecordingsBrowserTest. This ensures files are released and can be deleted, thus re-adding expectations on file delete success. Added hangup() function to peerconnection-call.html. BUG=697845 Review-Url: https://codereview.chromium.org/2764843002 Cr-Commit-Position: refs/heads/master@{#458375} Committed: https://chromium.googlesource.com/chromium/src/+/558e1295655666d3e80365af85de9b27b912eb6d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -9 lines) Patch
M content/browser/webrtc/webrtc_audio_debug_recordings_browsertest.cc View 6 chunks +12 lines, -9 lines 0 comments Download
M content/test/data/media/peerconnection-call.html View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Henrik Grunell
3 years, 9 months ago (2017-03-21 10:02:15 UTC) #3
Guido Urdaneta
lgtm
3 years, 9 months ago (2017-03-21 10:25:19 UTC) #4
ehmaldonado_chromium
On 2017/03/21 10:25:19, Guido Urdaneta wrote: > lgtm lgtm
3 years, 9 months ago (2017-03-21 11:23:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764843002/1
3 years, 9 months ago (2017-03-21 11:25:40 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 11:57:22 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/558e1295655666d3e80365af85de...

Powered by Google App Engine
This is Rietveld 408576698