Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2764833002: Move files in wtf/ to platform/wtf/ (Part 7). (Closed)

Created:
3 years, 9 months ago by Yuta Kitamura
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, kinuko+watch, blink-reviews-wtf_chromium.org, Mikhail
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move files in wtf/ to platform/wtf/ (Part 7). Now that I know I can move a .h file and a .cpp file independently, the constraints around the move become much simpler. In this round, many files that do not depend on WTFString are moved. The list of moved files is as follows: Assertions.cpp, Functional.h, HashTableDeletedValueType.h, InstanceCounter.h (.cpp remaining), LinkedStack.h, Locker.h, PassRefPtr.h, PtrUtil.h, RefCounted.h, RefPtr.h, StackUtil.h (.cpp remaining), StdLibExtras.h, ThreadRestrictionVerifier.h, ThreadSafeRefCounted.h, ThreadSpecific.h (.cpp remaining), Threading.h (.cpp remaining), ThreadingPrimitives.h, TreeNode.h, WeakPtr.h Additionally, the incorrect #include redirection in BitwiseOperations.h is fixed. BUG=691465 Review-Url: https://codereview.chromium.org/2764833002 Cr-Commit-Position: refs/heads/master@{#458671} Committed: https://chromium.googlesource.com/chromium/src/+/3e990f0c467ce30999724ac00f8cda56fd329db9

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -2753 lines) Patch
A + third_party/WebKit/Source/platform/wtf/Assertions.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/BUILD.gn View 1 2 chunks +18 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/Functional.h View 1 chunk +7 lines, -7 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/HashTableDeletedValueType.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/InstanceCounter.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/Locker.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/PassRefPtr.h View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/PtrUtil.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/RefCounted.h View 1 chunk +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/RefPtr.h View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/StackUtil.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/StdLibExtras.h View 1 chunk +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/ThreadRestrictionVerifier.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/ThreadSafeRefCounted.h View 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/ThreadSpecific.h View 1 chunk +8 lines, -8 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/Threading.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/ThreadingPrimitives.h View 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/TreeNode.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/WeakPtr.h View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/wtf/Assertions.cpp View 1 chunk +0 lines, -261 lines 0 comments Download
M third_party/WebKit/Source/wtf/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/BitwiseOperations.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/Functional.h View 1 chunk +7 lines, -298 lines 0 comments Download
M third_party/WebKit/Source/wtf/HashTableDeletedValueType.h View 1 chunk +7 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/wtf/InstanceCounter.h View 1 chunk +7 lines, -58 lines 0 comments Download
M third_party/WebKit/Source/wtf/Locker.h View 1 chunk +7 lines, -51 lines 0 comments Download
M third_party/WebKit/Source/wtf/PassRefPtr.h View 1 chunk +7 lines, -222 lines 0 comments Download
M third_party/WebKit/Source/wtf/PtrUtil.h View 1 chunk +5 lines, -49 lines 0 comments Download
M third_party/WebKit/Source/wtf/RefCounted.h View 1 chunk +7 lines, -169 lines 0 comments Download
M third_party/WebKit/Source/wtf/RefPtr.h View 1 chunk +7 lines, -220 lines 0 comments Download
M third_party/WebKit/Source/wtf/StackUtil.h View 1 chunk +4 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/wtf/StdLibExtras.h View 1 chunk +7 lines, -267 lines 0 comments Download
M third_party/WebKit/Source/wtf/ThreadRestrictionVerifier.h View 1 chunk +7 lines, -106 lines 0 comments Download
M third_party/WebKit/Source/wtf/ThreadSafeRefCounted.h View 1 chunk +7 lines, -84 lines 0 comments Download
M third_party/WebKit/Source/wtf/ThreadSpecific.h View 1 chunk +7 lines, -314 lines 0 comments Download
M third_party/WebKit/Source/wtf/Threading.h View 1 chunk +7 lines, -64 lines 0 comments Download
M third_party/WebKit/Source/wtf/ThreadingPrimitives.h View 1 chunk +7 lines, -173 lines 0 comments Download
M third_party/WebKit/Source/wtf/TreeNode.h View 1 chunk +7 lines, -210 lines 0 comments Download
M third_party/WebKit/Source/wtf/WeakPtr.h View 1 chunk +7 lines, -58 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (11 generated)
Yuta Kitamura
PTAL?
3 years, 9 months ago (2017-03-21 09:29:53 UTC) #4
haraken
LGTM
3 years, 9 months ago (2017-03-21 09:33:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764833002/20001
3 years, 9 months ago (2017-03-22 02:37:02 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder ...
3 years, 9 months ago (2017-03-22 04:38:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764833002/20001
3 years, 9 months ago (2017-03-22 07:28:23 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 07:40:07 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3e990f0c467ce30999724ac00f8c...

Powered by Google App Engine
This is Rietveld 408576698