Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 2764803002: MD History: Prevent flickering of 'no search results' message (Closed)

Created:
3 years, 9 months ago by tsergeant
Modified:
3 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Prevent flickering of 'no search results' message The 'no search results' message tries to hide itself whenever a backend query is in progress. This no longer has any useful effect (as the message is already hidden elsewhere), and just causes flickering of the message while typing a search query which has no results. This CL removes this redundant logic, fixing the flickering effect. BUG=616720 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2764803002 Cr-Commit-Position: refs/heads/master@{#458588} Committed: https://chromium.googlesource.com/chromium/src/+/bb694aba057b170bf406206c9ae3c5211e6669f1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M chrome/browser/resources/md_history/history_list.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/history_list.js View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
tsergeant
Here's a little code review for you~
3 years, 9 months ago (2017-03-21 06:14:28 UTC) #8
Dan Beam
lgtm
3 years, 9 months ago (2017-03-21 06:56:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764803002/1
3 years, 9 months ago (2017-03-21 22:33:15 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 22:42:19 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bb694aba057b170bf406206c9ae3...

Powered by Google App Engine
This is Rietveld 408576698