Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: ios/web_view/public/cwv_web_view.h

Issue 2764773002: Add CWVUserContentController which enables injecting JavaScripts. (Closed)
Patch Set: Add license. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web_view/public/cwv_web_view.h
diff --git a/ios/web_view/public/cwv_web_view.h b/ios/web_view/public/cwv_web_view.h
index b8e5f73c48c47bb178ee7745ab7c14d4b36f1daf..bd5b12ab215743bffb8922237decbf8e28f14af5 100644
--- a/ios/web_view/public/cwv_web_view.h
+++ b/ios/web_view/public/cwv_web_view.h
@@ -20,6 +20,8 @@
// Concrete instances can be created through CWV.
@interface CWVWebView : UIView
+@property(readonly, copy) CWVWebViewConfiguration* configuration;
michaeldo 2017/03/21 16:12:35 Is exposing this needed?
Eugene But (OOO till 7-30) 2017/03/21 16:47:55 nonatomic?
Eugene But (OOO till 7-30) 2017/03/21 16:47:55 This matches our API spec.
michaeldo 2017/03/21 17:24:03 Of course, sorry.
Hiroshi Ichikawa 2017/03/22 04:52:53 Done. BTW Many properties including this one are
Eugene But (OOO till 7-30) 2017/03/22 15:08:50 Copy affects getter, and will generate code simila
Hiroshi Ichikawa 2017/03/23 02:18:40 Hmm it looks it doesn't affect the getter as far a
Eugene But (OOO till 7-30) 2017/03/23 16:17:02 Maybe this is an optimization for immutable object
+
// The view used to display web content.
@property(nonatomic, readonly) UIView* view;
Eugene But (OOO till 7-30) 2017/03/21 16:47:55 Do we have a bug to remove this property?
Hiroshi Ichikawa 2017/03/22 04:52:53 I believe I have just forgotten to delete it. File

Powered by Google App Engine
This is Rietveld 408576698