Add CWVUserContentController which enables injecting JavaScripts.

ios/web_view/public/cwv_web_view.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #ifndef IOS_WEB_VIEW_PUBLIC_CWV_WEB_VIEW_H_
 #define IOS_WEB_VIEW_PUBLIC_CWV_WEB_VIEW_H_
 
 #import <UIKit/UIKit.h>
 
 @class CWVWebViewConfiguration;
 @protocol CWVUIDelegate;
 @protocol CWVTranslateDelegate;
 @protocol CWVNavigationDelegate;
 
 // A web view component (like WKWebView) which uses iOS Chromium's web view
 // implementation.
 //
 // In addition to WKWebView features, it allows Translate, Find In Page,
 // Customizable Context Menus, and maybe more.
 //
 // Concrete instances can be created through CWV.
 @interface CWVWebView : UIView
 
+@property(readonly, copy) CWVWebViewConfiguration* configuration;

[michaeldo, 2017/03/21 16:12:35]

Is exposing this needed?

[Eugene But (OOO till 7-30), 2017/03/21 16:47:55]

nonatomic?

[Eugene But (OOO till 7-30), 2017/03/21 16:47:55]

This matches our API spec.

[michaeldo, 2017/03/21 17:24:03]

Of course, sorry.

[Hiroshi Ichikawa, 2017/03/22 04:52:53]

Done.

BTW Many properties including this one are marked as (readonly, copy) in the
API, but isn't it meaningless? Doesn't "copy" only affect the setter, not
getter?

[Eugene But (OOO till 7-30), 2017/03/22 15:08:50]

Copy affects getter, and will generate code similar to this:
- (CWVWebViewConfiguration*)configuration {
  return [[_configuration copy] autorelease];
}
The main value for using |copy| is documenting the ownership

[Hiroshi Ichikawa, 2017/03/23 02:18:40]

Hmm it looks it doesn't affect the getter as far as I tested (see the test code
below). Am I missing something?
https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/Pr...
also mentions only about the setter but not getter for |copy|.

Maybe |retain| is better for documentation purpose if it actually doesn't copy?

#import <Foundation/Foundation.h>

@interface Foo : NSObject
@property(nonatomic, readonly, copy) NSObject* bar;
- (instancetype)init;
@end

@implementation Foo

- (instancetype)init {
  self = [super init];
  if (self) {
    _bar = [[NSObject alloc] init];
  }
  return self;
}

@end

int main() {
  Foo* foo = [[Foo alloc] init];
  NSObject* bar1 = foo.bar;
  NSObject* bar2 = foo.bar;
  NSLog(@"bar1 = %@", bar1);
  // => bar1 = <NSObject: 0x7fce2f400430>
  NSLog(@"bar2 = %@", bar2);
  // => bar2 = <NSObject: 0x7fce2f400430>
  return 0;
}

[Eugene But (OOO till 7-30), 2017/03/23 16:17:02]

Maybe this is an optimization for immutable objects, like NSObject? Or maybe I
don't understand Objective-C :)

+
 // The view used to display web content.
 @property(nonatomic, readonly) UIView* view;

[Eugene But (OOO till 7-30), 2017/03/21 16:47:55]

Do we have a bug to remove this property?

[Hiroshi Ichikawa, 2017/03/22 04:52:53]

I believe I have just forgotten to delete it. Filed crbug.com/703981.

 
 // This web view's navigation delegate.
 @property(nonatomic, weak) id<CWVNavigationDelegate> navigationDelegate;
 
 // This web view's UI delegate
 @property(nonatomic, weak) id<CWVUIDelegate> UIDelegate;
 
 // A delegate for the translation feature.
 @property(nonatomic, weak) id<CWVTranslateDelegate> translationDelegate;
 
@@ skipping 41 matching lines @@
 - (void)loadRequest:(NSURLRequest*)request;
 
 // Evaluates a JavaScript string.
 // The completion handler is invoked when script evaluation completes.
 - (void)evaluateJavaScript:(NSString*)javaScriptString
          completionHandler:(void (^)(id, NSError*))completionHandler;
 
 @end
 
 #endif  // IOS_WEB_VIEW_PUBLIC_CWV_WEB_VIEW_H_