Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

Issue 2764743004: Add DocumentMarker::createGrammarMarker() and createSpellingMarker() (Closed)
Patch Set: Move test case changes into createTextMatchMarker() CL Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
index 3a823ce66b060d9b7b3b2e3ce722e44bb6d9cd0b..074b12ecb743fd4247b9af2c46e2697da8380c91 100644
--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
@@ -64,14 +64,22 @@ void DocumentMarkerController::addMarker(const Position& start,
const Position& end,
DocumentMarker::MarkerType type,
const String& description) {
+ DCHECK(type == DocumentMarker::Grammar || type == DocumentMarker::Spelling);
// Use a TextIterator to visit the potentially multiple nodes the range
// covers.
for (TextIterator markedText(start, end); !markedText.atEnd();
markedText.advance()) {
- addMarker(markedText.currentContainer(),
- new DocumentMarker(
- type, markedText.startOffsetInCurrentContainer(),
- markedText.endOffsetInCurrentContainer(), description));
+ DocumentMarker* marker;
+ if (type == DocumentMarker::Grammar) {
yosin_UTC9 2017/03/23 04:01:27 Could you add TODO for introducing add{Grammaer,Sp
+ marker = DocumentMarker::createGrammarMarker(
+ markedText.startOffsetInCurrentContainer(),
+ markedText.endOffsetInCurrentContainer(), description);
+ } else {
+ marker = DocumentMarker::createSpellingMarker(
+ markedText.startOffsetInCurrentContainer(),
+ markedText.endOffsetInCurrentContainer(), description);
+ }
+ addMarker(markedText.currentContainer(), marker);
}
}

Powered by Google App Engine
This is Rietveld 408576698