Add DocumentMarker::createGrammarMarker() and createSpellingMarker()

third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
@@ skipping 46 matching lines @@
   for (DocumentMarker::MarkerType type : DocumentMarker::AllMarkers()) {
     MarkerMap& markerMap = markerMapForType(type);
     markerMap.clear();
   }
 }
 
 void DocumentMarkerController::addMarker(const Position& start,
                                          const Position& end,
                                          DocumentMarker::MarkerType type,
                                          const String& description) {
+  DCHECK(type == DocumentMarker::Grammar || type == DocumentMarker::Spelling);
   // Use a TextIterator to visit the potentially multiple nodes the range
   // covers.
   for (TextIterator markedText(start, end); !markedText.atEnd();
        markedText.advance()) {
-    addMarker(markedText.currentContainer(),
-              new DocumentMarker(
-                  type, markedText.startOffsetInCurrentContainer(),
-                  markedText.endOffsetInCurrentContainer(), description));
+    DocumentMarker* marker;
+    if (type == DocumentMarker::Grammar) {

[yosin_UTC9, 2017/03/23 04:01:27]

Could you add TODO for introducing add{Grammaer,Spelling}Marker()?
We want to expose DocumentMarker::MarkerType.

+      marker = DocumentMarker::createGrammarMarker(
+          markedText.startOffsetInCurrentContainer(),
+          markedText.endOffsetInCurrentContainer(), description);
+    } else {
+      marker = DocumentMarker::createSpellingMarker(
+          markedText.startOffsetInCurrentContainer(),
+          markedText.endOffsetInCurrentContainer(), description);
+    }
+    addMarker(markedText.currentContainer(), marker);
   }
 }
 
 void DocumentMarkerController::addTextMatchMarker(const EphemeralRange& range,
                                                   bool activeMatch) {
   DCHECK(!m_document->needsLayoutTreeUpdate());
 
   // Use a TextIterator to visit the potentially multiple nodes the range
   // covers.
   for (TextIterator markedText(range.startPosition(), range.endPosition());
@@ skipping 481 matching lines @@
 }
 
 }  // namespace blink
 
 #ifndef NDEBUG
 void showDocumentMarkers(const blink::DocumentMarkerController* controller) {
   if (controller)
     controller->showMarkers();
 }
 #endif