Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarker.h

Issue 2764743004: Add DocumentMarker::createGrammarMarker() and createSpellingMarker() (Closed)
Patch Set: Move test case changes into createTextMatchMarker() CL Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/markers/DocumentMarker.h
diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h b/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h
index f09a4f3b36d02385ba9e69fc788a45ec18c810de..c81da8816b78ce285b764edf29d471604238b10c 100644
--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h
+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h
@@ -139,15 +139,18 @@ class CORE_EXPORT DocumentMarker : public GarbageCollected<DocumentMarker> {
Color underlineColor,
bool thick,
Color backgroundColor);
+ static DocumentMarker* createGrammarMarker(
rlanday 2017/03/22 21:07:00 I think we should pick whether we want to order th
yosin_UTC9 2017/03/23 04:01:27 My personal preference is alphabetical order, sinc
+ unsigned startOffset,
+ unsigned endOffset,
+ const String& description = emptyString);
+ static DocumentMarker* createSpellingMarker(
+ unsigned startOffset,
+ unsigned endOffset,
+ const String& description = emptyString);
static DocumentMarker* createTextMatchMarker(unsigned startOffset,
unsigned endOffset,
bool activeMatch);
- DocumentMarker(MarkerType,
- unsigned startOffset,
- unsigned endOffset,
- const String& description);
-
DocumentMarker(const DocumentMarker&);
MarkerType type() const { return m_type; }

Powered by Google App Engine
This is Rietveld 408576698