Add DocumentMarker::createGrammarMarker() and createSpellingMarker()

third_party/WebKit/Source/core/editing/markers/DocumentMarker.h

 /*
  * This file is part of the DOM implementation for WebCore.
  *
  * Copyright (C) 2006 Apple Computer, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 121 matching lines @@
   class SpellCheckClientMarkers : public MarkerTypes {
    public:
     SpellCheckClientMarkers() : MarkerTypes(Spelling | Grammar) {}
   };
 
   static DocumentMarker* createCompositionMarker(unsigned startOffset,
                                                  unsigned endOffset,
                                                  Color underlineColor,
                                                  bool thick,
                                                  Color backgroundColor);
+  static DocumentMarker* createGrammarMarker(

[rlanday, 2017/03/22 21:07:00]

I think we should pick whether we want to order these methods alphabetically or
in order of the MarkerType enum, and use the same ordering here and in
DocumentMarkerController for the add*Marker() methods

[yosin_UTC9, 2017/03/23 04:01:27]

My personal preference is alphabetical order, since we can do without context.
But, there are many opinions.

Please do reordering if you want in another CL.

+      unsigned startOffset,
+      unsigned endOffset,
+      const String& description = emptyString);
+  static DocumentMarker* createSpellingMarker(
+      unsigned startOffset,
+      unsigned endOffset,
+      const String& description = emptyString);
   static DocumentMarker* createTextMatchMarker(unsigned startOffset,
                                                unsigned endOffset,
                                                bool activeMatch);
 
-  DocumentMarker(MarkerType,
-                 unsigned startOffset,
-                 unsigned endOffset,
-                 const String& description);
-
   DocumentMarker(const DocumentMarker&);
 
   MarkerType type() const { return m_type; }
   unsigned startOffset() const { return m_startOffset; }
   unsigned endOffset() const { return m_endOffset; }
 
   const String& description() const;
   bool activeMatch() const;
   Color underlineColor() const;
   bool thick() const;
@@ skipping 55 matching lines @@
   virtual bool isDescription() const { return false; }
   virtual bool isTextMatch() const { return false; }
   virtual bool isComposition() const { return false; }
 
   DEFINE_INLINE_VIRTUAL_TRACE() {}
 };
 
 }  // namespace blink
 
 #endif  // DocumentMarker_h