Add DocumentMarker::createGrammarMarker() and createSpellingMarker()

third_party/WebKit/Source/core/editing/markers/DocumentMarker.h

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarker.h
diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h b/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h
index 15a2a73a344889550e86ce5ebac4109bdba2ab8e..f8cc85d8e4cc24b139b9bb7ef178ca8e4af591a8 100644
--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h
+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h
@@ -96,15 +96,18 @@ class CORE_EXPORT DocumentMarker : public GarbageCollected<DocumentMarker> {
                                                  Color underlineColor,
                                                  bool thick,
                                                  Color backgroundColor);
+  static DocumentMarker* createGrammarMarker(
+      unsigned startOffset,
+      unsigned endOffset,
+      const String& description = emptyString);

[Xiaocheng, 2017/03/22 01:42:51]

No need to introduce default parameter.

Btw, it seems simpler to just renaming the existing ctor to
DM::createSpellCheckMarker(type, startOffset, endOffset, description). It also
reduces code duplication.

[rlanday, 2017/03/22 01:51:30]

Oh oops, I think the default param is supposed to be in the
DocumentMarkerController method for adding a marker.
That's an option, but then we lose the 1-to-1 mapping between MarkerType and the
create method, and we have to worry about how to handle callers that pass a
MarkerType other than Grammar or Spelling (we could use a bool but I don't like
that either)

[Xiaocheng, 2017/03/22 01:56:07]

I'm fine with having two ctors.

+  static DocumentMarker* createSpellingMarker(
+      unsigned startOffset,
+      unsigned endOffset,
+      const String& description = emptyString);
   static DocumentMarker* createTextMatchMarker(unsigned startOffset,
                                                unsigned endOffset,
                                                bool activeMatch);
 
-  DocumentMarker(MarkerType,
-                 unsigned startOffset,
-                 unsigned endOffset,
-                 const String& description);
-
   DocumentMarker(const DocumentMarker&);
 
   MarkerType type() const { return m_type; }