Add DocumentMarker::createGrammarMarker() and createSpellingMarker()

third_party/WebKit/Source/core/editing/markers/DocumentMarker.h

 /*
  * This file is part of the DOM implementation for WebCore.
  *
  * Copyright (C) 2006 Apple Computer, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 78 matching lines @@
   class SpellCheckClientMarkers : public MarkerTypes {
    public:
     SpellCheckClientMarkers() : MarkerTypes(Spelling | Grammar) {}
   };
 
   static DocumentMarker* createCompositionMarker(unsigned startOffset,
                                                  unsigned endOffset,
                                                  Color underlineColor,
                                                  bool thick,
                                                  Color backgroundColor);
+  static DocumentMarker* createGrammarMarker(
+      unsigned startOffset,
+      unsigned endOffset,
+      const String& description = emptyString);

[Xiaocheng, 2017/03/22 01:42:51]

No need to introduce default parameter.

Btw, it seems simpler to just renaming the existing ctor to
DM::createSpellCheckMarker(type, startOffset, endOffset, description). It also
reduces code duplication.

[rlanday, 2017/03/22 01:51:30]

Oh oops, I think the default param is supposed to be in the
DocumentMarkerController method for adding a marker.
That's an option, but then we lose the 1-to-1 mapping between MarkerType and the
create method, and we have to worry about how to handle callers that pass a
MarkerType other than Grammar or Spelling (we could use a bool but I don't like
that either)

[Xiaocheng, 2017/03/22 01:56:07]

I'm fine with having two ctors.

+  static DocumentMarker* createSpellingMarker(
+      unsigned startOffset,
+      unsigned endOffset,
+      const String& description = emptyString);
   static DocumentMarker* createTextMatchMarker(unsigned startOffset,
                                                unsigned endOffset,
                                                bool activeMatch);
 
-  DocumentMarker(MarkerType,
-                 unsigned startOffset,
-                 unsigned endOffset,
-                 const String& description);
-
   DocumentMarker(const DocumentMarker&);
 
   MarkerType type() const { return m_type; }
   unsigned startOffset() const { return m_startOffset; }
   unsigned endOffset() const { return m_endOffset; }
 
   const String& description() const;
   bool activeMatch() const;
   Color underlineColor() const;
   bool thick() const;
@@ skipping 55 matching lines @@
   virtual bool isDescription() const { return false; }
   virtual bool isTextMatch() const { return false; }
   virtual bool isComposition() const { return false; }
 
   DEFINE_INLINE_VIRTUAL_TRACE() {}
 };
 
 }  // namespace blink
 
 #endif  // DocumentMarker_h