Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Issue 2764733002: Add black background to ARC maximzied window (Closed)

Created:
3 years, 9 months ago by oshima
Modified:
3 years, 9 months ago
Reviewers:
reveman
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add black background to ARC maximzied window as well as fullscreen. BUG=703731 TEST=unit tests, manual Review-Url: https://codereview.chromium.org/2764733002 Cr-Commit-Position: refs/heads/master@{#458609} Committed: https://chromium.googlesource.com/chromium/src/+/69232cda736bc8b0570bc833ceb2323bf6bcd451

Patch Set 1 : ARC maximzied window should also have a black background #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M components/exo/shell_surface.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M components/exo/shell_surface_unittest.cc View 3 chunks +19 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (17 generated)
oshima
3 years, 9 months ago (2017-03-21 18:11:50 UTC) #11
reveman
lgtm
3 years, 9 months ago (2017-03-21 22:00:37 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764733002/40001
3 years, 9 months ago (2017-03-21 23:42:56 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 01:37:06 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/69232cda736bc8b0570bc833ceb2...

Powered by Google App Engine
This is Rietveld 408576698