Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 2764683002: Remove stale-while-revalidate from content and chrome (Closed)

Created:
3 years, 9 months ago by scottmg
Modified:
3 years, 9 months ago
Reviewers:
jam
CC:
chromium-reviews, jam, Randy Smith (Not in Mondays), darin-cc_chromium.org, asvitkine+watch_chromium.org, loading-reviews_chromium.org, srahim+watch_chromium.org, Adam Rice
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stale-while-revalidate from content and chrome This removes the code for the stale-while-revalidate experiment from content and the flags entry from chrome. This simplifies some c/b/loader separation particularly in resource_dispatcher_host_impl.cc. See https://bugs.chromium.org/p/chromium/issues/detail?id=348877#c66 for details on the experiment turndown. BUG=348877, 700568 Review-Url: https://codereview.chromium.org/2764683002 Cr-Commit-Position: refs/heads/master@{#458613} Committed: https://chromium.googlesource.com/chromium/src/+/2625374404695b3c1c5e62c0b7921fdde1395c7c

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2014 lines) Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/BUILD.gn View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/loader/DEPS View 2 chunks +0 lines, -31 lines 0 comments Download
M content/browser/loader/async_resource_handler_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
D content/browser/loader/async_revalidation_driver.h View 1 chunk +0 lines, -99 lines 0 comments Download
D content/browser/loader/async_revalidation_driver.cc View 1 chunk +0 lines, -264 lines 0 comments Download
D content/browser/loader/async_revalidation_driver_unittest.cc View 1 chunk +0 lines, -403 lines 0 comments Download
D content/browser/loader/async_revalidation_manager.h View 1 chunk +0 lines, -107 lines 0 comments Download
D content/browser/loader/async_revalidation_manager.cc View 1 chunk +0 lines, -194 lines 0 comments Download
D content/browser/loader/async_revalidation_manager_browsertest.cc View 1 chunk +0 lines, -250 lines 0 comments Download
D content/browser/loader/async_revalidation_manager_unittest.cc View 1 chunk +0 lines, -558 lines 0 comments Download
M content/browser/loader/netlog_observer_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.h View 3 chunks +0 lines, -9 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 11 chunks +1 line, -67 lines 0 comments Download
M content/browser/loader/resource_request_info_impl.h View 3 chunks +0 lines, -3 lines 0 comments Download
M content/browser/loader/resource_request_info_impl.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M content/public/common/content_features.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_features.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/test/BUILD.gn View 1 2 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 28 (19 generated)
scottmg
3 years, 9 months ago (2017-03-21 18:02:54 UTC) #17
mmenke
Are there plans to remove the support code from net/, too?
3 years, 9 months ago (2017-03-21 18:08:48 UTC) #18
scottmg
On 2017/03/21 18:08:48, mmenke wrote: > Are there plans to remove the support code from ...
3 years, 9 months ago (2017-03-21 18:17:50 UTC) #19
jam
nice, lgtm
3 years, 9 months ago (2017-03-21 23:59:48 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764683002/40001
3 years, 9 months ago (2017-03-22 00:14:07 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/2625374404695b3c1c5e62c0b7921fdde1395c7c
3 years, 9 months ago (2017-03-22 01:44:11 UTC) #25
mmenke
On 2017/03/21 18:17:50, scottmg wrote: > On 2017/03/21 18:08:48, mmenke wrote: > > Are there ...
3 years, 9 months ago (2017-03-22 15:49:37 UTC) #26
scottmg
On 2017/03/22 15:49:37, mmenke wrote: > On 2017/03/21 18:17:50, scottmg wrote: > > On 2017/03/21 ...
3 years, 9 months ago (2017-03-22 15:51:25 UTC) #27
agrieve
3 years, 9 months ago (2017-03-22 16:54:02 UTC) #28
Message was sent while issue was closed.
On 2017/03/22 15:51:25, scottmg wrote:
> On 2017/03/22 15:49:37, mmenke wrote:
> > On 2017/03/21 18:17:50, scottmg wrote:
> > > On 2017/03/21 18:08:48, mmenke wrote:
> > > > Are there plans to remove the support code from net/, too?
> > > 
> > > Yeah, I was going to ask if it made sense to do that or there was
> potentially
> > > any other consumer of it.
> > > 
> > > I'll remove it from net/ in a subsequent CL.
> > 
> > Sorry, missed your response.  SGTM.  I don't believe there are an other
> > consumers of it.
> 
> Great, thanks. I'll send you a CL shortly.

fyi - this reduced libchrome.so on Android by 18kb. Thanks for the clean-up!

Powered by Google App Engine
This is Rietveld 408576698