Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2764643002: Add interactive UI test for Select-to-Speak (Closed)

Created:
3 years, 9 months ago by dmazzoni
Modified:
3 years, 9 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add interactive UI test for Select-to-Speak BUG=593887 Review-Url: https://codereview.chromium.org/2764643002 Cr-Commit-Position: refs/heads/master@{#458809} Committed: https://chromium.googlesource.com/chromium/src/+/f5fe21b84963871f36db0d1d26d4febe3cea9a67

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address feedback #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -0 lines) Patch
A chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc View 1 1 chunk +64 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
dmazzoni
This is not meant to be comprehensive, just an initial sanity test to get a ...
3 years, 9 months ago (2017-03-20 21:46:22 UTC) #2
David Tseng
lgtm https://codereview.chromium.org/2764643002/diff/1/chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc File chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc (right): https://codereview.chromium.org/2764643002/diff/1/chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc#newcode1 chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc:1: // Copyright (c) 2017 The Chromium Authors. All ...
3 years, 9 months ago (2017-03-20 23:40:20 UTC) #3
dmazzoni
https://codereview.chromium.org/2764643002/diff/1/chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc File chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc (right): https://codereview.chromium.org/2764643002/diff/1/chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc#newcode1 chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc:1: // Copyright (c) 2017 The Chromium Authors. All rights ...
3 years, 9 months ago (2017-03-21 22:40:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764643002/20001
3 years, 9 months ago (2017-03-21 22:41:10 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/390874)
3 years, 9 months ago (2017-03-21 22:57:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764643002/40001
3 years, 9 months ago (2017-03-22 17:14:25 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 18:25:46 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f5fe21b84963871f36db0d1d26d4...

Powered by Google App Engine
This is Rietveld 408576698