Add interactive UI test for Select-to-Speak

Add interactive UI test for Select-to-Speak

BUG=593887
Review-Url: https://codereview.chromium.org/2764643002
Cr-Commit-Position: refs/heads/master@{#458809}
Committed: https://chromium.googlesource.com/chromium/src/+/f5fe21b84963871f36db0d1d26d4febe3cea9a67

[dmazzoni, 2017-03-20 21:46:22]

dmazzoni@chromium.org changed reviewers:
+ dtseng@chromium.org

[dmazzoni, 2017-03-20 21:46:22]

This is not meant to be comprehensive, just an initial
sanity test to get a working text fixture in place.

[David Tseng, 2017-03-20 23:40:20]

lgtm

https://codereview.chromium.org/2764643002/diff/1/chrome/browser/chromeos/acc...
File chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc
(right):

https://codereview.chromium.org/2764643002/diff/1/chrome/browser/chromeos/acc...
chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc:1: //
Copyright (c) 2017 The Chromium Authors. All rights reserved.
nit: (c) not needed?

https://codereview.chromium.org/2764643002/diff/1/chrome/browser/chromeos/acc...
chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc:43:
aura::Window* root_window_;
This need not be a class member.

https://codereview.chromium.org/2764643002/diff/1/chrome/browser/chromeos/acc...
chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc:54:
generator_->PressKey(ui::VKEY_LWIN, 0);
0 /* ??? */

[dmazzoni, 2017-03-21 22:40:15]

https://codereview.chromium.org/2764643002/diff/1/chrome/browser/chromeos/acc...
File chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc
(right):

https://codereview.chromium.org/2764643002/diff/1/chrome/browser/chromeos/acc...
chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc:1: //
Copyright (c) 2017 The Chromium Authors. All rights reserved.
On 2017/03/20 23:40:20, David Tseng wrote:
> nit: (c) not needed?

Done.

https://codereview.chromium.org/2764643002/diff/1/chrome/browser/chromeos/acc...
chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc:43:
aura::Window* root_window_;
On 2017/03/20 23:40:20, David Tseng wrote:
> This need not be a class member.

Done.

https://codereview.chromium.org/2764643002/diff/1/chrome/browser/chromeos/acc...
chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc:54:
generator_->PressKey(ui::VKEY_LWIN, 0);
On 2017/03/20 23:40:20, David Tseng wrote:
> 0 /* ??? */

Done (flags)

[dmazzoni, 2017-03-21 22:40:27]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2017-03-21 22:40:28]

The patchset sent to the CQ was uploaded after l-g-t-m from dtseng@chromium.org
Link to the patchset: https://codereview.chromium.org/2764643002/#ps20001
(title: "Address feedback")

[commit-bot: I haz the power, 2017-03-21 22:41:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 22:57:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 22:57:55]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dmazzoni, 2017-03-22 17:13:52]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2017-03-22 17:13:53]

The patchset sent to the CQ was uploaded after l-g-t-m from dtseng@chromium.org
Link to the patchset: https://codereview.chromium.org/2764643002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-22 17:14:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 18:25:00]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490202832781150,
"parent_rev": "d864bc1dd103a8905734988823dee69e52e04940", "commit_rev":
"f5fe21b84963871f36db0d1d26d4febe3cea9a67"}

[commit-bot: I haz the power, 2017-03-22 18:25:45]

Description was changed from

==========
Add interactive UI test for Select-to-Speak

BUG=593887
==========

to

==========
Add interactive UI test for Select-to-Speak

BUG=593887

Review-Url: https://codereview.chromium.org/2764643002
Cr-Commit-Position: refs/heads/master@{#458809}
Committed:
https://chromium.googlesource.com/chromium/src/+/f5fe21b84963871f36db0d1d26d4...
==========

[commit-bot: I haz the power, 2017-03-22 18:25:46]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f5fe21b84963871f36db0d1d26d4...