Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2764633003:
Fixing Display Mirror Mode issue (Closed)
|
Created:
3 years, 9 months ago by stanisc Modified:
3 years, 9 months ago Reviewers:
danakj CC:
chromium-reviews, jam, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, afakhry Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFixing Display Mirror Mode issue
As a part of https://codereview.chromium.org/2626413002 I've
inadvertently removed an unrelated line of code that sets
display_output_surface field on per-compositor data.
See line 565 here:
https://codereview.chromium.org/2626413002/diff/120001/content/browser/compositor/gpu_process_transport_factory.cc
This change puts the removed line of code back.
Thanks to afakhry@ for verifying the fix!
BUG=702713
Review-Url: https://codereview.chromium.org/2764633003
Cr-Commit-Position: refs/heads/master@{#458587}
Committed: https://chromium.googlesource.com/chromium/src/+/165005de11ad4207b3003a42a3ce41f4ab797e67
Patch Set 1 #
Messages
Total messages: 19 (12 generated)
The CQ bit was checked by stanisc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Fixing Display Mirror Mode issue BUG=702713 ========== to ========== Fixing Display Mirror Mode issue As a part of https://codereview.chromium.org/2626413002 I've inadvertently removed an unrelated line of code that sets display_output_surface field on per-compositor data. See line 565 here: https://codereview.chromium.org/2626413002/diff/120001/content/browser/compos... This change puts the removed line of code back. BUG=702713 ==========
Description was changed from ========== Fixing Display Mirror Mode issue As a part of https://codereview.chromium.org/2626413002 I've inadvertently removed an unrelated line of code that sets display_output_surface field on per-compositor data. See line 565 here: https://codereview.chromium.org/2626413002/diff/120001/content/browser/compos... This change puts the removed line of code back. BUG=702713 ========== to ========== Fixing Display Mirror Mode issue As a part of https://codereview.chromium.org/2626413002 I've inadvertently removed an unrelated line of code that sets display_output_surface field on per-compositor data. See line 565 here: https://codereview.chromium.org/2626413002/diff/120001/content/browser/compos... This change puts the removed line of code back. Thanks to afakhry@ for verifying the fix! BUG=702713 ==========
stanisc@chromium.org changed reviewers: + danakj@chromium.org
PTAL!
LGTM is there a unit test you could add for this?
On 2017/03/21 16:01:24, danakj wrote: > LGTM is there a unit test you could add for this? Good question. I though about a unit test but this whole factory class is kind of an integration class which depends on a lot of concrete configurations and connects together a lot of concrete pieces - might be difficult to unit test. I'll file a new issue to track the lack of unit test coverage of this class.
The CQ bit was checked by stanisc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by stanisc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490135475931340, "parent_rev":
"8c33c0a01a0f30089c4741e56c6f43703771dd90", "commit_rev":
"165005de11ad4207b3003a42a3ce41f4ab797e67"}
Message was sent while issue was closed.
Description was changed from ========== Fixing Display Mirror Mode issue As a part of https://codereview.chromium.org/2626413002 I've inadvertently removed an unrelated line of code that sets display_output_surface field on per-compositor data. See line 565 here: https://codereview.chromium.org/2626413002/diff/120001/content/browser/compos... This change puts the removed line of code back. Thanks to afakhry@ for verifying the fix! BUG=702713 ========== to ========== Fixing Display Mirror Mode issue As a part of https://codereview.chromium.org/2626413002 I've inadvertently removed an unrelated line of code that sets display_output_surface field on per-compositor data. See line 565 here: https://codereview.chromium.org/2626413002/diff/120001/content/browser/compos... This change puts the removed line of code back. Thanks to afakhry@ for verifying the fix! BUG=702713 Review-Url: https://codereview.chromium.org/2764633003 Cr-Commit-Position: refs/heads/master@{#458587} Committed: https://chromium.googlesource.com/chromium/src/+/165005de11ad4207b3003a42a3ce... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/165005de11ad4207b3003a42a3ce... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
