Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 2764633003: Fixing Display Mirror Mode issue (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months ago by stanisc
Modified:
7 months ago
Reviewers:
danakj
CC:
chromium-reviews, jam, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, afakhry
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing Display Mirror Mode issue As a part of https://codereview.chromium.org/2626413002 I've inadvertently removed an unrelated line of code that sets display_output_surface field on per-compositor data. See line 565 here: https://codereview.chromium.org/2626413002/diff/120001/content/browser/compositor/gpu_process_transport_factory.cc This change puts the removed line of code back. Thanks to afakhry@ for verifying the fix! BUG=702713 Review-Url: https://codereview.chromium.org/2764633003 Cr-Commit-Position: refs/heads/master@{#458587} Committed: https://chromium.googlesource.com/chromium/src/+/165005de11ad4207b3003a42a3ce41f4ab797e67

Patch Set 1 #

Messages

Total messages: 19 (12 generated)
stanisc
PTAL!
7 months ago (2017-03-21 01:43:39 UTC) #8
danakj
LGTM is there a unit test you could add for this?
7 months ago (2017-03-21 16:01:24 UTC) #9
stanisc
On 2017/03/21 16:01:24, danakj wrote: > LGTM is there a unit test you could add ...
7 months ago (2017-03-21 18:16:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764633003/1
7 months ago (2017-03-21 18:17:57 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/390529)
7 months ago (2017-03-21 18:23:28 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764633003/1
7 months ago (2017-03-21 22:32:07 UTC) #16
commit-bot: I haz the power
7 months ago (2017-03-21 22:41:00 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/165005de11ad4207b3003a42a3ce...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 81bcdb8aa