[FRE] Unify chrome://welcome and chrome://welcome-win10 button styles.

[FRE] Unify chrome://welcome and chrome://welcome-win10 button styles.

The "SIGN IN" button in chrome://welcome and the "CONTINUE" button in
chrome://welcome-win10 are styled differently. This CL unifies them.
Details:
- "SIGN IN": Fix color on mousedown, so that it does not turn dark as
  with the case for keyboard nav.
- "SIGN IN": Copy "CONTINUE" button's :hover style, shadow, and
  animation.
- "CONTINUE": Gain dark color when focused by keyboard nav.

BUG=657106
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2764623002
Cr-Commit-Position: refs/heads/master@{#459108}
Committed: https://chromium.googlesource.com/chromium/src/+/8fe88eadb09b3307f897d17f1306fdaa78afe36f

[huangs, 2017-03-20 21:09:47]

Description was changed from

==========
[FRE] Make chrome://welcome buttons consistent between non-Win10 and Win10.

The "SIGN IN" button in chrome://welcome and the "CONTINUE" button in
chrome://welcome-win10 look very different. This CL unifies them; in
particular:
- "SIGN IN": Fix color on mousedown, so that it does not turn dark as
  with the case when button is focused by keyboard nav.
- "SIGN IN": Copy "CONTINUE" button's :hover style, outline, and
  animation.
- "CONTINUE": Gains dark color when focused by keyboard nav.

BUG=657106
==========

to

==========
[FRE] Make chrome://welcome buttons consistent between non-Win10 and Win10.

The "SIGN IN" button in chrome://welcome and the "CONTINUE" button in
chrome://welcome-win10 look very different. This CL unifies them; in
particular:
- "SIGN IN": Fix color on mousedown, so that it does not turn dark as
  with the case when button is focused by keyboard nav.
- "SIGN IN": Copy "CONTINUE" button's :hover style, outline, and
  animation.
- "CONTINUE": Gains dark color when focused by keyboard nav.

BUG=657106
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[huangs, 2017-03-20 21:34:58]

Description was changed from

==========
[FRE] Make chrome://welcome buttons consistent between non-Win10 and Win10.

The "SIGN IN" button in chrome://welcome and the "CONTINUE" button in
chrome://welcome-win10 look very different. This CL unifies them; in
particular:
- "SIGN IN": Fix color on mousedown, so that it does not turn dark as
  with the case when button is focused by keyboard nav.
- "SIGN IN": Copy "CONTINUE" button's :hover style, outline, and
  animation.
- "CONTINUE": Gains dark color when focused by keyboard nav.

BUG=657106
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[FRE] Make chrome://welcome buttons consistent between non-Win10 and Win10.

The "SIGN IN" button in chrome://welcome and the "CONTINUE" button in
chrome://welcome-win10 look very different. This CL unifies them; in
particular:
- "SIGN IN": Fix color on mousedown, so that it does not turn dark as
  with the case for keyboard nav.
- "SIGN IN": Copy "CONTINUE" button's :hover style, shadow, and
  animation.
- "CONTINUE": Gain dark color when focused by keyboard nav.

BUG=657106
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[huangs, 2017-03-21 21:03:28]

Description was changed from

==========
[FRE] Make chrome://welcome buttons consistent between non-Win10 and Win10.

The "SIGN IN" button in chrome://welcome and the "CONTINUE" button in
chrome://welcome-win10 look very different. This CL unifies them; in
particular:
- "SIGN IN": Fix color on mousedown, so that it does not turn dark as
  with the case for keyboard nav.
- "SIGN IN": Copy "CONTINUE" button's :hover style, shadow, and
  animation.
- "CONTINUE": Gain dark color when focused by keyboard nav.

BUG=657106
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[FRE] Unify chrome://welcome and chrome://welcome-win10 button styles.

The "SIGN IN" button in chrome://welcome and the "CONTINUE" button in
chrome://welcome-win10 are styled differently. This CL unifies them.
Details:
- "SIGN IN": Fix color on mousedown, so that it does not turn dark as
  with the case for keyboard nav.
- "SIGN IN": Copy "CONTINUE" button's :hover style, shadow, and
  animation.
- "CONTINUE": Gain dark color when focused by keyboard nav.

BUG=657106
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[huangs, 2017-03-21 21:03:29]

huangs@chromium.org changed reviewers:
+ tmartino@chromium.org, tommycli@chromium.org

[huangs, 2017-03-21 21:03:37]

PTAL. Thanks!

[tmartino, 2017-03-22 18:04:43]

lgtm

https://codereview.chromium.org/2764623002/diff/1/chrome/browser/resources/we...
File chrome/browser/resources/welcome/welcome.css (right):

https://codereview.chromium.org/2764623002/diff/1/chrome/browser/resources/we...
chrome/browser/resources/welcome/welcome.css:197: box-shadow: inset 0 0 0 1px
rgba(0, 0, 0, .1), 0 1px 2px rgba(0, 0, 0, .24)
;

[tommycli, 2017-03-22 18:23:25]

On 2017/03/22 18:04:43, tmartino wrote:
> lgtm
> 
>
https://codereview.chromium.org/2764623002/diff/1/chrome/browser/resources/we...
> File chrome/browser/resources/welcome/welcome.css (right):
> 
>
https://codereview.chromium.org/2764623002/diff/1/chrome/browser/resources/we...
> chrome/browser/resources/welcome/welcome.css:197: box-shadow: inset 0 0 0 1px
> rgba(0, 0, 0, .1), 0 1px 2px rgba(0, 0, 0, .24)
> ;

rs lgtm

[huangs, 2017-03-22 20:15:08]

Thanks. Committing!

https://codereview.chromium.org/2764623002/diff/1/chrome/browser/resources/we...
File chrome/browser/resources/welcome/welcome.css (right):

https://codereview.chromium.org/2764623002/diff/1/chrome/browser/resources/we...
chrome/browser/resources/welcome/welcome.css:197: box-shadow: inset 0 0 0 1px
rgba(0, 0, 0, .1), 0 1px 2px rgba(0, 0, 0, .24)
Good catch! Also fixing this in inline.html.

[huangs, 2017-03-22 20:15:19]

The CQ bit was checked by huangs@chromium.org

[huangs, 2017-03-22 20:15:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
tmartino@chromium.org, tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2764623002/#ps20001
(title: "Add missing ';'.")

[commit-bot: I haz the power, 2017-03-22 20:16:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 21:16:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 21:16:06]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[huangs, 2017-03-23 15:35:55]

The CQ bit was checked by huangs@chromium.org

[commit-bot: I haz the power, 2017-03-23 15:36:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 16:21:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490283355150500,
"parent_rev": "3da3338bfc027c0b7a48e5b033feb04f24792b17", "commit_rev":
"8fe88eadb09b3307f897d17f1306fdaa78afe36f"}

[commit-bot: I haz the power, 2017-03-23 16:22:44]

Description was changed from

==========
[FRE] Unify chrome://welcome and chrome://welcome-win10 button styles.

The "SIGN IN" button in chrome://welcome and the "CONTINUE" button in
chrome://welcome-win10 are styled differently. This CL unifies them.
Details:
- "SIGN IN": Fix color on mousedown, so that it does not turn dark as
  with the case for keyboard nav.
- "SIGN IN": Copy "CONTINUE" button's :hover style, shadow, and
  animation.
- "CONTINUE": Gain dark color when focused by keyboard nav.

BUG=657106
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[FRE] Unify chrome://welcome and chrome://welcome-win10 button styles.

The "SIGN IN" button in chrome://welcome and the "CONTINUE" button in
chrome://welcome-win10 are styled differently. This CL unifies them.
Details:
- "SIGN IN": Fix color on mousedown, so that it does not turn dark as
  with the case for keyboard nav.
- "SIGN IN": Copy "CONTINUE" button's :hover style, shadow, and
  animation.
- "CONTINUE": Gain dark color when focused by keyboard nav.

BUG=657106
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2764623002
Cr-Commit-Position: refs/heads/master@{#459108}
Committed:
https://chromium.googlesource.com/chromium/src/+/8fe88eadb09b3307f897d17f1306...
==========

[commit-bot: I haz the power, 2017-03-23 16:22:47]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8fe88eadb09b3307f897d17f1306...