Fix race condition in content_shell which could lead to an assert on shutdown with PlzNavigate.

Fix race condition in content_shell which could lead to an assert on shutdown with PlzNavigate.

The problem is that URLRequestContext's destructor checks that there are no more outstanding requests, while ResourceContext's destructor is what removes outstanding requests. In Chrome's profile implementation, the order is correct, but content_shell had a bug. This only mattered with PlzNavigate because renderer requests are deleted earlier through other codepaths.

This should fix the flakiness seen on the Marshmallow 64 bit Tester with PlzNavigate.

BUG=673806
Review-Url: https://codereview.chromium.org/2764613002
Cr-Original-Commit-Position: refs/heads/master@{#458216}
Committed: https://chromium.googlesource.com/chromium/src/+/18bf53b4ccb6351759ca4a0bdc30a814aeb61137
Review-Url: https://codereview.chromium.org/2764613002
Cr-Commit-Position: refs/heads/master@{#458523}
Committed: https://chromium.googlesource.com/chromium/src/+/21e62ae7504024888b56ae4e42d810d94812e0ae

[jam, 2017-03-20 20:21:43]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 20:22:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-03-20 20:30:19]

Description was changed from

==========
Fix race condition in content_shell which could lead to an assert on shutdown
with PlzNavigate.

The problem is that URLRequestContext's destructor checks that there are no more
outstanding requests, while ResourceContext's destructor is what removes
outstanding requests. In Chrome's profile implementation, the order is correct,
but content_shell had a bug. This only mattered with PlzNavigate because
renderer requests are deleted earlier through other codepaths.

BUG=673806
==========

to

==========
Fix race condition in content_shell which could lead to an assert on shutdown
with PlzNavigate.

The problem is that URLRequestContext's destructor checks that there are no more
outstanding requests, while ResourceContext's destructor is what removes
outstanding requests. In Chrome's profile implementation, the order is correct,
but content_shell had a bug. This only mattered with PlzNavigate because
renderer requests are deleted earlier through other codepaths.

This should fix the flakiness seen on the Marshmallow 64 bit Tester with
PlzNavigate.

BUG=673806
==========

[commit-bot: I haz the power, 2017-03-20 21:13:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 21:13:36]

Dry run: This issue passed the CQ dry run.

[jam, 2017-03-20 21:24:48]

jam@chromium.org changed reviewers:
+ avi@chromium.org

[Avi (use Gerrit), 2017-03-20 21:29:47]

lgtm

[jam, 2017-03-20 21:45:52]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-03-20 21:46:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 22:55:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490046352123370, "parent_rev":
"2f74b825a9c1e204af1693480a62c386ce33c4f4", "commit_rev":
"18bf53b4ccb6351759ca4a0bdc30a814aeb61137"}

[commit-bot: I haz the power, 2017-03-20 22:56:09]

Description was changed from

==========
Fix race condition in content_shell which could lead to an assert on shutdown
with PlzNavigate.

The problem is that URLRequestContext's destructor checks that there are no more
outstanding requests, while ResourceContext's destructor is what removes
outstanding requests. In Chrome's profile implementation, the order is correct,
but content_shell had a bug. This only mattered with PlzNavigate because
renderer requests are deleted earlier through other codepaths.

This should fix the flakiness seen on the Marshmallow 64 bit Tester with
PlzNavigate.

BUG=673806
==========

to

==========
Fix race condition in content_shell which could lead to an assert on shutdown
with PlzNavigate.

The problem is that URLRequestContext's destructor checks that there are no more
outstanding requests, while ResourceContext's destructor is what removes
outstanding requests. In Chrome's profile implementation, the order is correct,
but content_shell had a bug. This only mattered with PlzNavigate because
renderer requests are deleted earlier through other codepaths.

This should fix the flakiness seen on the Marshmallow 64 bit Tester with
PlzNavigate.

BUG=673806

Review-Url: https://codereview.chromium.org/2764613002
Cr-Commit-Position: refs/heads/master@{#458216}
Committed:
https://chromium.googlesource.com/chromium/src/+/18bf53b4ccb6351759ca4a0bdc30...
==========

[commit-bot: I haz the power, 2017-03-20 22:56:09]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/18bf53b4ccb6351759ca4a0bdc30...

[horo, 2017-03-21 04:00:57]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2761223002/ by horo@chromium.org.

The reason for reverting is: Introduced
ServiceWorkerNavigationPreloadTest.NetworkError crashes on Debug build.

BUG=703439
.

[jam, 2017-03-21 15:55:38]

Description was changed from

==========
Fix race condition in content_shell which could lead to an assert on shutdown
with PlzNavigate.

The problem is that URLRequestContext's destructor checks that there are no more
outstanding requests, while ResourceContext's destructor is what removes
outstanding requests. In Chrome's profile implementation, the order is correct,
but content_shell had a bug. This only mattered with PlzNavigate because
renderer requests are deleted earlier through other codepaths.

This should fix the flakiness seen on the Marshmallow 64 bit Tester with
PlzNavigate.

BUG=673806

Review-Url: https://codereview.chromium.org/2764613002
Cr-Commit-Position: refs/heads/master@{#458216}
Committed:
https://chromium.googlesource.com/chromium/src/+/18bf53b4ccb6351759ca4a0bdc30...
==========

to

==========
Fix race condition in content_shell which could lead to an assert on shutdown
with PlzNavigate.

The problem is that URLRequestContext's destructor checks that there are no more
outstanding requests, while ResourceContext's destructor is what removes
outstanding requests. In Chrome's profile implementation, the order is correct,
but content_shell had a bug. This only mattered with PlzNavigate because
renderer requests are deleted earlier through other codepaths.

This should fix the flakiness seen on the Marshmallow 64 bit Tester with
PlzNavigate.

BUG=673806

Review-Url: https://codereview.chromium.org/2764613002
Cr-Commit-Position: refs/heads/master@{#458216}
Committed:
https://chromium.googlesource.com/chromium/src/+/18bf53b4ccb6351759ca4a0bdc30...
==========

[jam, 2017-03-21 16:43:29]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 16:44:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-03-21 17:27:14]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 17:28:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-03-21 17:43:59]

Avi: ptal for the dcheck fix in patchset 3. This fired on win dbg bots and
repros locally.

The problem is that service worker requests won't have a frame id set, so
ResourceDispatcherHostImpl::OnRenderFrameDeleted won't clear them.

In debugging this I found that we don't always shut down the URLRequestContext
in contetn correctly, I filed
https://bugs.chromium.org/p/chromium/issues/detail?id=703718

[jam, 2017-03-21 18:18:40]

jam@chromium.org changed reviewers:
+ nasko@chromium.org
- avi@chromium.org

[jam, 2017-03-21 18:18:41]

->Nasko since Avi is ooo

[commit-bot: I haz the power, 2017-03-21 18:29:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 18:29:32]

Dry run: This issue passed the CQ dry run.

[jam, 2017-03-21 19:50:03]

jam@chromium.org changed reviewers:
+ avi@chromium.org
- nasko@chromium.org

[Avi (use Gerrit), 2017-03-21 19:50:39]

lgtm

[jam, 2017-03-21 19:51:03]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-03-21 19:51:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 19:57:54]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490125863468010,
"parent_rev": "d7323d358bb4c28778915daef88f72407e078bd0", "commit_rev":
"21e62ae7504024888b56ae4e42d810d94812e0ae"}

[commit-bot: I haz the power, 2017-03-21 19:59:04]

Description was changed from

==========
Fix race condition in content_shell which could lead to an assert on shutdown
with PlzNavigate.

The problem is that URLRequestContext's destructor checks that there are no more
outstanding requests, while ResourceContext's destructor is what removes
outstanding requests. In Chrome's profile implementation, the order is correct,
but content_shell had a bug. This only mattered with PlzNavigate because
renderer requests are deleted earlier through other codepaths.

This should fix the flakiness seen on the Marshmallow 64 bit Tester with
PlzNavigate.

BUG=673806

Review-Url: https://codereview.chromium.org/2764613002
Cr-Commit-Position: refs/heads/master@{#458216}
Committed:
https://chromium.googlesource.com/chromium/src/+/18bf53b4ccb6351759ca4a0bdc30...
==========

to

==========
Fix race condition in content_shell which could lead to an assert on shutdown
with PlzNavigate.

The problem is that URLRequestContext's destructor checks that there are no more
outstanding requests, while ResourceContext's destructor is what removes
outstanding requests. In Chrome's profile implementation, the order is correct,
but content_shell had a bug. This only mattered with PlzNavigate because
renderer requests are deleted earlier through other codepaths.

This should fix the flakiness seen on the Marshmallow 64 bit Tester with
PlzNavigate.

BUG=673806

Review-Url: https://codereview.chromium.org/2764613002
Cr-Original-Commit-Position: refs/heads/master@{#458216}
Committed:
https://chromium.googlesource.com/chromium/src/+/18bf53b4ccb6351759ca4a0bdc30...
Review-Url: https://codereview.chromium.org/2764613002
Cr-Commit-Position: refs/heads/master@{#458523}
Committed:
https://chromium.googlesource.com/chromium/src/+/21e62ae7504024888b56ae4e42d8...
==========

[commit-bot: I haz the power, 2017-03-21 19:59:06]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/21e62ae7504024888b56ae4e42d8...