Copy D-Bus service files to build output.

Copy D-Bus service files to build output.

This is done so that chromite can copy these files from the build_output
to remove this step from an ebuild in ChromeOS. This also makes "Simple
Chrome" installs more closely match standard Chrome installs on
ChromeOS.

I've confirmed that dbus/org.chromium.LibCrosService.conf and
dbus/org.chromium.LivenessService.conf are created in the output
directory when performing a chrome build for a chromeos board.

BUG=701617
Review-Url: https://codereview.chromium.org/2764513002
Cr-Commit-Position: refs/heads/master@{#458083}
Committed: https://chromium.googlesource.com/chromium/src/+/822d58e6b22506cbd4787b58d8ccb421409b5b65

[teravest, 2017-03-20 15:11:02]

teravest@chromium.org changed reviewers:
+ derat@chromium.org

[Daniel Erat, 2017-03-20 15:14:25]

lgtm

https://codereview.chromium.org/2764513002/diff/1/chromeos/BUILD.gn
File chromeos/BUILD.gn (right):

https://codereview.chromium.org/2764513002/diff/1/chromeos/BUILD.gn#newcode470
chromeos/BUILD.gn:470: "dbus/services/org.chromium.LivenessService.conf",
i think there's no way to use a wildcard here, right? can you add a README.md
file in dbus/services/ mentioning that .conf files need to be listed in this
target? (it doesn't need to happen as part of this change.)

[teravest, 2017-03-20 15:23:51]

Patchset #2 (id:20001) has been deleted

[teravest, 2017-03-20 15:29:39]

On 2017/03/20 15:14:25, Daniel Erat wrote:
> lgtm
> 
> https://codereview.chromium.org/2764513002/diff/1/chromeos/BUILD.gn
> File chromeos/BUILD.gn (right):
> 
> https://codereview.chromium.org/2764513002/diff/1/chromeos/BUILD.gn#newcode470
> chromeos/BUILD.gn:470: "dbus/services/org.chromium.LivenessService.conf",
> i think there's no way to use a wildcard here, right? can you add a README.md
> file in dbus/services/ mentioning that .conf files need to be listed in this
> target? (it doesn't need to happen as part of this change.)

I don't see any wildcards used for file names in GN files.
Adding a README.md sounds reasonable to me, done.

[teravest, 2017-03-20 15:35:48]

The CQ bit was checked by teravest@chromium.org

[teravest, 2017-03-20 15:35:49]

The patchset sent to the CQ was uploaded after l-g-t-m from derat@chromium.org
Link to the patchset: https://codereview.chromium.org/2764513002/#ps40001
(title: "Add README.md")

[commit-bot: I haz the power, 2017-03-20 15:36:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 16:32:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490024148926140,
"parent_rev": "34fb331c43ae36ce0a10705f6e5e93f0efbba87d", "commit_rev":
"822d58e6b22506cbd4787b58d8ccb421409b5b65"}

[commit-bot: I haz the power, 2017-03-20 16:33:38]

Description was changed from

==========
Copy D-Bus service files to build output.

This is done so that chromite can copy these files from the build_output
to remove this step from an ebuild in ChromeOS. This also makes "Simple
Chrome" installs more closely match standard Chrome installs on
ChromeOS.

I've confirmed that dbus/org.chromium.LibCrosService.conf and
dbus/org.chromium.LivenessService.conf are created in the output
directory when performing a chrome build for a chromeos board.

BUG=701617
==========

to

==========
Copy D-Bus service files to build output.

This is done so that chromite can copy these files from the build_output
to remove this step from an ebuild in ChromeOS. This also makes "Simple
Chrome" installs more closely match standard Chrome installs on
ChromeOS.

I've confirmed that dbus/org.chromium.LibCrosService.conf and
dbus/org.chromium.LivenessService.conf are created in the output
directory when performing a chrome build for a chromeos board.

BUG=701617

Review-Url: https://codereview.chromium.org/2764513002
Cr-Commit-Position: refs/heads/master@{#458083}
Committed:
https://chromium.googlesource.com/chromium/src/+/822d58e6b22506cbd4787b58d8cc...
==========

[commit-bot: I haz the power, 2017-03-20 16:33:38]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/822d58e6b22506cbd4787b58d8cc...