Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2764443002: Utility process: use interfaces rather than overloaded term services (Closed)

Created:
3 years, 9 months ago by Noel Gordon
Modified:
3 years, 9 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Utility process: use interfaces rather than overloaded term services The term "service" gets overloaded a lot. Since services are a real thing and not the same thing as mojom interfaces, it's important to distinguish them in code and comments [1]. Here fix the comments in the utility process where we should'a used the word "interfaces". No change in behaviour, no new tests. [1] https://codereview.chromium.org/2697463002/#msg203 BUG=691410 Review-Url: https://codereview.chromium.org/2764443002 Cr-Commit-Position: refs/heads/master@{#458374} Committed: https://chromium.googlesource.com/chromium/src/+/bcca171b7b0b1bf4b086d66b0906d2ff8cc2a4f4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/utility/chrome_content_utility_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/extensions/extensions_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/utility/utility_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (12 generated)
Noel Gordon
Ken, PTAL, you mentioned this while reviewing my patch ... https://codereview.chromium.org/2697463002/#msg203
3 years, 9 months ago (2017-03-20 12:39:20 UTC) #4
Ken Rockot(use gerrit already)
Thanks! LGTM
3 years, 9 months ago (2017-03-20 16:00:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764443002/1
3 years, 9 months ago (2017-03-20 20:49:08 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/389593)
3 years, 9 months ago (2017-03-20 21:14:44 UTC) #12
Noel Gordon
+jochen for OWNERS.
3 years, 9 months ago (2017-03-20 21:19:13 UTC) #14
jochen (gone - plz use gerrit)
lgtm
3 years, 9 months ago (2017-03-21 10:30:35 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764443002/1
3 years, 9 months ago (2017-03-21 11:15:30 UTC) #17
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 11:20:39 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bcca171b7b0b1bf4b086d66b0906...

Powered by Google App Engine
This is Rietveld 408576698