Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 2764413003: [WASM] Fix failing WASM SIMD tests. (Closed)

Created:
3 years, 9 months ago by bbudge
Modified:
3 years, 9 months ago
Reviewers:
Mircea Trofin
CC:
v8-reviews_googlegroups.com, Michael Achenbach, dusan.simicic, Rodolph Perfetta (ARM)
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[WASM] Fix failing WASM SIMD tests. - Skips test when expected value is very small or large. - Renames methods to make more sense. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2764413003 Cr-Commit-Position: refs/heads/master@{#44045} Committed: https://chromium.googlesource.com/v8/v8/+/2747ab31ef64c7d2d0e5d726962bd9a382b0b0e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M test/cctest/wasm/test-run-wasm-simd.cc View 6 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
bbudge
3 years, 9 months ago (2017-03-22 18:30:34 UTC) #4
Mircea Trofin
On 2017/03/22 18:30:34, bbudge wrote: Lgtm (+My portability concern)
3 years, 9 months ago (2017-03-22 19:16:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764413003/1
3 years, 9 months ago (2017-03-22 19:17:34 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 19:18:56 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2747ab31ef64c7d2d0e5d726962bd9a382b...

Powered by Google App Engine
This is Rietveld 408576698