cc : Make visible rect independant of render surface's is_clipped value

cc : Make visible rect independant of render surface's is_clipped value

This is needed to move render surface's is_clipped value computation
later in the pipeline (during render surface layer list computation)

BUG=702010
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2764343006
Cr-Commit-Position: refs/heads/master@{#459853}
Committed: https://chromium.googlesource.com/chromium/src/+/c1f7bf4dd89d99927cc99ae6f7ad92a567684110

[jaydasika, 2017-03-24 01:15:44]

Description was changed from

==========
cc : Make visible rect independant of render surface's is_clipped value

This is needed to move render surface's is_clipped value computation
later in the pipeline (during render surface layer list computation)

BUG=702010
==========

to

==========
cc : Make visible rect independant of render surface's is_clipped value

This is needed to move render surface's is_clipped value computation
later in the pipeline (during render surface layer list computation)

BUG=702010
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[jaydasika, 2017-03-24 01:17:58]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 01:18:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jaydasika, 2017-03-24 01:19:41]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, weiliangc@chromium.org

[jaydasika, 2017-03-24 01:19:42]

PTAL

[commit-bot: I haz the power, 2017-03-24 03:39:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 03:39:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[weiliangc, 2017-03-24 18:52:25]

https://codereview.chromium.org/2764343006/diff/20001/cc/trees/draw_property_...
File cc/trees/draw_property_utils.cc (right):

https://codereview.chromium.org/2764343006/diff/20001/cc/trees/draw_property_...
cc/trees/draw_property_utils.cc:658: if (fully_visible) {
Do we still need to check for fully_visible here? Even when a layer is not
clipped and its target surface isn't clipped, the layer is still under the
influence of the clip node right? We could use clip node's accumulated rect in
screen space in both cases?

[jaydasika, 2017-03-24 23:11:33]

https://codereview.chromium.org/2764343006/diff/20001/cc/trees/draw_property_...
File cc/trees/draw_property_utils.cc (right):

https://codereview.chromium.org/2764343006/diff/20001/cc/trees/draw_property_...
cc/trees/draw_property_utils.cc:658: if (fully_visible) {
On 2017/03/24 18:52:25, weiliangc wrote:
> Do we still need to check for fully_visible here? Even when a layer is not
> clipped and its target surface isn't clipped, the layer is still under the
> influence of the clip node right? We could use clip node's accumulated rect in
> screen space in both cases?

There was a layout test failure which made me think we need this case. But,
after logging the values for that test I realized, the visible rect was smaller
when we use viewport clip instead of accumulated rect. So, I think its just a
snapping issue and rebaselining the test should be ok ?
The reason using just viewport clip results in smaller visible rect is : the
page has a blur filter which causes the accumulated clip to expand, so the
accumulated clip is larger than viewport clip.

[jaydasika, 2017-03-24 23:11:45]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 23:12:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-25 00:52:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-25 00:52:08]

Dry run: This issue passed the CQ dry run.

[weiliangc, 2017-03-27 15:44:24]

LGTM

[jaydasika, 2017-03-27 17:02:00]

+ pdr / chrishtr for blink : This CL fixes correctness, it removes a fast-path
for computing visible rects which did not account for visible rect expansion due
to filters. Now, the expansion is accounted for and so the layout test needs
rebaseline.

[jaydasika, 2017-03-27 17:02:58]

jaydasika@chromium.org changed reviewers:
+ chrishtr@chromium.org, pdr@chromium.org

[jaydasika, 2017-03-27 17:02:59]

+ pdr / chrishtr for blink : This CL fixes correctness, it removes a fast path
for computing visible rects which did not account for visible rect expansion due
to filters. Now, the expansion is accounted for and so the
layout test needs rebaseline.

[chrishtr, 2017-03-27 17:33:17]

lgtm

[jaydasika, 2017-03-27 17:36:27]

The CQ bit was checked by jaydasika@chromium.org

[commit-bot: I haz the power, 2017-03-27 17:37:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 19:37:50]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490636187372650,
"parent_rev": "300fa54be51e2d3969e11937e5e8ed97d546bfac", "commit_rev":
"c1f7bf4dd89d99927cc99ae6f7ad92a567684110"}

[commit-bot: I haz the power, 2017-03-27 19:38:39]

Description was changed from

==========
cc : Make visible rect independant of render surface's is_clipped value

This is needed to move render surface's is_clipped value computation
later in the pipeline (during render surface layer list computation)

BUG=702010
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc : Make visible rect independant of render surface's is_clipped value

This is needed to move render surface's is_clipped value computation
later in the pipeline (during render surface layer list computation)

BUG=702010
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2764343006
Cr-Commit-Position: refs/heads/master@{#459853}
Committed:
https://chromium.googlesource.com/chromium/src/+/c1f7bf4dd89d99927cc99ae6f7ad...
==========

[commit-bot: I haz the power, 2017-03-27 19:38:40]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c1f7bf4dd89d99927cc99ae6f7ad...