Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(961)

Issue 2764333003: Support PolicyWatcher with custom loader for testing (Closed)

Created:
3 years, 9 months ago by rkjnsn
Modified:
3 years, 8 months ago
Reviewers:
Sergey Ulanov, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Support PolicyWatcher with custom loader for testing PolicyWatcher::Create automatically creates an underlying AsyncPolicyLoader corresponding to the policy storage location of the current platform. This commit adds an alternative constructor, CreateFromPolicyLoaderForTesting, which allows a custom AsyncPolicyLoader to be specified to allow testing other components with different policy configurations. Review-Url: https://codereview.chromium.org/2764333003 Cr-Commit-Position: refs/heads/master@{#460592} Committed: https://chromium.googlesource.com/chromium/src/+/d0aa1e57ed2f964784b89b70c77a51b1bf833af1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M remoting/host/policy_watcher.h View 1 chunk +8 lines, -0 lines 0 comments Download
M remoting/host/policy_watcher.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M remoting/host/policy_watcher_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
rkjnsn
This is an alternative to https://codereview.chromium.org/2710023003/ which provides the needed functionality much less invasively, and ...
3 years, 9 months ago (2017-03-22 22:31:31 UTC) #2
Sergey Ulanov
lgtm
3 years, 9 months ago (2017-03-23 01:11:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764333003/1
3 years, 8 months ago (2017-03-29 22:15:25 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 00:18:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d0aa1e57ed2f964784b89b70c77a...

Powered by Google App Engine
This is Rietveld 408576698