Clean up Debugger::NotifyMessageHandler.

Clean up Debugger::NotifyMessageHandler.

R=ulan@chromium.org

[ulan, 2014-05-09 08:10:34]

https://codereview.chromium.org/276433004/diff/1/src/debug.cc
File src/debug.cc (right):

https://codereview.chromium.org/276433004/diff/1/src/debug.cc#newcode3117
src/debug.cc:3117: isolate_, cmd_processor_ctor, exec_state, 1,
ctor_args).ToHandleChecked();
Why did you remove v8::TryCatch try_catch here and below?

https://codereview.chromium.org/276433004/diff/1/src/debug.cc#newcode3160
src/debug.cc:3160: request_text->PrintLn();
Will this compile with release without object-printing enabled?

[Yang, 2014-05-09 08:36:14]

https://codereview.chromium.org/276433004/diff/1/src/debug.cc
File src/debug.cc (right):

https://codereview.chromium.org/276433004/diff/1/src/debug.cc#newcode3117
src/debug.cc:3117: isolate_, cmd_processor_ctor, exec_state, 1,
ctor_args).ToHandleChecked();
On 2014/05/09 08:10:34, ulan wrote:
> Why did you remove v8::TryCatch try_catch here and below?

We don't expect this to fail. If it indeed does, something terrible happened and
we are better off crashing in ToHandleChecked().

Judging from the old code, I'm not surprised about anything anymore, even a
stray try-catch.

https://codereview.chromium.org/276433004/diff/1/src/debug.cc#newcode3160
src/debug.cc:3160: request_text->PrintLn();
On 2014/05/09 08:10:34, ulan wrote:
> Will this compile with release without object-printing enabled?

You are right. Fixed that.

[ulan, 2014-05-09 08:46:43]

lgtm