Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 276433002: Defer to generate breakpad symbols to decide whether or not to dump symbols (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews
Visibility:
Public.

Description

Defer to generate breakpad symbols to decide whether or not to dump symbols When using shared libraries, the main binary might not have been touched even if one of the dependencies was updated. BUG=369608 R=dpranke@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173544

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py View 1 chunk +1 line, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-05-07 10:34:05 UTC) #1
Dirk Pranke
lgtm, though I think you have typos in your description ... "mine binary"?
6 years, 7 months ago (2014-05-07 15:30:35 UTC) #2
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 7 months ago (2014-05-07 15:36:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/276433002/1
6 years, 7 months ago (2014-05-07 15:36:58 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-07 16:43:19 UTC) #5
Message was sent while issue was closed.
Change committed as 173544

Powered by Google App Engine
This is Rietveld 408576698