Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Unified Diff: Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py

Issue 276433002: Defer to generate breakpad symbols to decide whether or not to dump symbols (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py b/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py
index a94a7a50f5aef61798c0cc4301bf93b188d07eb4..b79b3f0e1dad163e2181e902f3c72a037e9d2719 100644
--- a/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py
+++ b/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py
@@ -122,19 +122,7 @@ class DumpReaderMultipart(DumpReader):
return self._host.filesystem.join(self._build_dir, 'content_shell.syms')
def _generate_breakpad_symbols_if_necessary(self):
- if self._host.filesystem.exists(self._symbols_dir()):
- needs_update = False
- symbols_mtime = self._host.filesystem.mtime(self._symbols_dir())
- for binary in self._binaries_to_symbolize():
- full_path = self._host.filesystem.join(self._build_dir, binary)
- if self._host.filesystem.mtime(full_path) >= symbols_mtime:
- needs_update = True
- if not needs_update:
- return
-
- _log.debug("Regenerating breakpad symbols")
- self._host.filesystem.rmtree(self._symbols_dir())
-
+ _log.debug("Generating breakpad symbols")
for binary in self._binaries_to_symbolize():
full_path = self._host.filesystem.join(self._build_dir, binary)
cmd = [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698