Move plugins to be stored in HTMLPlugInElement.

third_party/WebKit/Source/core/dom/Document.cpp

Index: third_party/WebKit/Source/core/dom/Document.cpp
diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp
index 4b13bb38c904c0136d401125492162169f56e062..e4ba1f1483a524bc375549e7e064f7863525906b 100644
--- a/third_party/WebKit/Source/core/dom/Document.cpp
+++ b/third_party/WebKit/Source/core/dom/Document.cpp
@@ -4044,6 +4044,7 @@ bool Document::setFocusedElement(Element* prpNewFocusedElement,
       }
     }
 
+    // TODO(joelhockey): Do we need spcial handling for plugins?

[dcheng, 2017/03/23 07:21:42]

Unfortunately, I'm pretty sure the answer here is yes: things like browser
plugin expect to be notified about focus changes.

[joelhockey, 2017/03/27 06:42:21]

I can confirm that plugin is expecting a call here.  For now I have modified
frameViewBaseForElement to return either PluginView or FrameView and use the
FrameViewBase polymorphism to call setFocused.  My plan once I remove
FrameViewBase class is to create a Focusable ABC that FrameView and PluginView
will both implement.  Then frameViewBaseForElement will be renamed to
getFocusableFromElement and return Focusable class.

     if (view()) {
       FrameViewBase* oldFrameViewBase =
           frameViewBaseForElement(*oldFocusedElement);
@@ -4120,6 +4121,7 @@ bool Document::setFocusedElement(Element* prpNewFocusedElement,
     // eww, I suck. set the qt focus correctly
     // ### find a better place in the code for this
     if (view()) {
+      // TODO(joelhockey): Do we need special handling for plugins?
       FrameViewBase* focusFrameViewBase =
           frameViewBaseForElement(*m_focusedElement);
       if (focusFrameViewBase) {