Move plugins to be stored in HTMLPlugInElement.

third_party/WebKit/Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
@@ skipping 4026 matching lines @@
                                                newFocusedElement,
                                                params.sourceCapabilities);
 
       if (m_focusedElement) {
         // handler shifted focus
         focusChangeBlocked = true;
         newFocusedElement = nullptr;
       }
     }
 
+    // TODO(joelhockey): Do we need spcial handling for plugins?

[dcheng, 2017/03/23 07:21:42]

Unfortunately, I'm pretty sure the answer here is yes: things like browser
plugin expect to be notified about focus changes.

[joelhockey, 2017/03/27 06:42:21]

I can confirm that plugin is expecting a call here.  For now I have modified
frameViewBaseForElement to return either PluginView or FrameView and use the
FrameViewBase polymorphism to call setFocused.  My plan once I remove
FrameViewBase class is to create a Focusable ABC that FrameView and PluginView
will both implement.  Then frameViewBaseForElement will be renamed to
getFocusableFromElement and return Focusable class.

     if (view()) {
       FrameViewBase* oldFrameViewBase =
           frameViewBaseForElement(*oldFocusedElement);
       if (oldFrameViewBase)
         oldFrameViewBase->setFocused(false, params.type);
       else
         view()->setFocused(false, params.type);
     }
   }
 
@@ skipping 56 matching lines @@
         goto SetFocusedElementDone;
       }
     }
 
     if (isRootEditableElement(*m_focusedElement))
       frame()->spellChecker().didBeginEditing(m_focusedElement.get());
 
     // eww, I suck. set the qt focus correctly
     // ### find a better place in the code for this
     if (view()) {
+      // TODO(joelhockey): Do we need special handling for plugins?
       FrameViewBase* focusFrameViewBase =
           frameViewBaseForElement(*m_focusedElement);
       if (focusFrameViewBase) {
         // Make sure a FrameViewBase has the right size before giving it focus.
         // Otherwise, we are testing edge cases of the FrameViewBase code.
         // Specifically, in WebCore this does not work well for text fields.
         updateStyleAndLayout();
         // Re-get the FrameViewBase in case updating the layout changed things.
         focusFrameViewBase = frameViewBaseForElement(*m_focusedElement);
       }
@@ skipping 2521 matching lines @@
 }
 
 void showLiveDocumentInstances() {
   WeakDocumentSet& set = liveDocumentSet();
   fprintf(stderr, "There are %u documents currently alive:\n", set.size());
   for (blink::Document* document : set)
     fprintf(stderr, "- Document %p URL: %s\n", document,
             document->url().getString().utf8().data());
 }
 #endif