Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2764293002: Add LayoutTests for the fixed multithread GC bug of ServiceWorker Navigation Preload (Closed)

Created:
3 years, 9 months ago by horo
Modified:
3 years, 9 months ago
Reviewers:
falken, haraken
CC:
chromium-reviews, michaeln, mlamouri+watch-content_chromium.org, kenjibaheux+watch_chromium.org, tzik, jsbell+serviceworker_chromium.org, Peter Beverloo, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, jochen+watch_chromium.org, horo+watch_chromium.org, blink-reviews, darin-cc_chromium.org, kinuko+watch, shimazu+serviceworker_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add LayoutTests for the fixed multithread GC bug of ServiceWorker Navigation Preload BUG=702527 Review-Url: https://codereview.chromium.org/2764293002 Cr-Commit-Position: refs/heads/master@{#459348} Committed: https://chromium.googlesource.com/chromium/src/+/85f49a916b4835ec93379a0eaeb4f125b66f6270

Patch Set 1 : with the revert of https://crbug.com/702527#c9 for checking the crashing test results #

Patch Set 2 : with crbug.com/702527#c9 #

Total comments: 6

Patch Set 3 : incorporated falken's comment #

Messages

Total messages: 22 (15 generated)
horo
falken@ Could you please review this?
3 years, 9 months ago (2017-03-23 05:33:25 UTC) #11
falken
lgtm. the sleeps are unfortunate but seem unavoidable unless Oilpan team knows of a better ...
3 years, 9 months ago (2017-03-23 06:19:02 UTC) #12
horo
Thank you. https://codereview.chromium.org/2764293002/diff/40001/third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/chromium/navigation-preload-after-gc.html File third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/chromium/navigation-preload-after-gc.html (right): https://codereview.chromium.org/2764293002/diff/40001/third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/chromium/navigation-preload-after-gc.html#newcode9 third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/chromium/navigation-preload-after-gc.html:9: // This test simulate the flowing situation: ...
3 years, 9 months ago (2017-03-23 06:46:39 UTC) #13
horo
haraken@ Could you please review this?
3 years, 9 months ago (2017-03-23 06:47:04 UTC) #15
haraken
LGTM
3 years, 9 months ago (2017-03-23 07:05:02 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764293002/60001
3 years, 9 months ago (2017-03-24 00:46:22 UTC) #19
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 03:05:45 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/85f49a916b4835ec93379a0eaeb4...

Powered by Google App Engine
This is Rietveld 408576698