Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2764173003: Convert chrome InstrumentationTestCases to JUnit4 [2] (Closed)

Created:
3 years, 9 months ago by the real yoland
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, wifiprefetch-reviews_google.com
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert chrome InstrumentationTestCases to JUnit4 [2] These tests are direct children of InstrumentationTestCase. Some test cases needed to run on UiThread. For more on JUnit4 migration, check src/testing/android/docs/junit4.md BUG=640116

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+686 lines, -472 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/identity/SettingsSecureBasedIdentificationGeneratorTest.java View 5 chunks +12 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/identity/UniqueIdentificationGeneratorFactoryTest.java View 3 chunks +16 lines, -9 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/identity/UuidBasedUniqueIdentificationGeneratorTest.java View 3 chunks +18 lines, -11 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarControlLayoutTest.java View 6 chunks +46 lines, -37 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/invalidation/DelayedInvalidationsControllerTest.java View 8 chunks +48 lines, -26 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/omaha/ExponentialBackoffSchedulerTest.java View 7 chunks +26 lines, -16 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/omaha/OmahaBaseTest.java View 17 chunks +76 lines, -60 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/omaha/RequestGeneratorTest.java View 8 chunks +25 lines, -12 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/omaha/StringSanitizerTest.java View 1 chunk +12 lines, -6 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java View 16 chunks +66 lines, -49 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheControllerTest.java View 4 chunks +68 lines, -35 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManagerTest.java View 5 chunks +14 lines, -7 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/signin/OAuth2TokenServiceTest.java View 7 chunks +29 lines, -18 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/signin/SigninHelperTest.java View 5 chunks +40 lines, -24 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/tab/TabIdManagerTest.java View 3 chunks +26 lines, -13 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/tab/TabRedirectHandlerTest.java View 8 chunks +164 lines, -145 lines 0 comments Download

Depends on Patchset:

Issue 2760153002 Patch 100001

Messages

Total messages: 4 (4 generated)
the real yoland
The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-22 04:16:53 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764173003/1
3 years, 9 months ago (2017-03-22 04:17:31 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-22 06:19:06 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 06:19:07 UTC) #4 
Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't
started yet, builder probably lacks capacity)

Powered by Google App Engine
This is Rietveld 408576698