Use SkCanvas::SkCanvas(SkBitmap) instead of going thru SkSurface

Use SkCanvas::SkCanvas(SkBitmap) instead of going thru SkSurface

I learnt that you can just wrap an SkBitmap with an SkCanvas for cases
like these. SkSurface is a more general thing when your backing may
not be in cpu memory or when you have more complicated SkImageInfo.
For us, it is coming from the SkBitmap which is cpu memory-backed. So
this is simpler code.

R=oshima@chromium.org, pkasting@chromium.org, sadrul@chromium.org
BUG=671433
Review-Url: https://codereview.chromium.org/2764163002
Cr-Commit-Position: refs/heads/master@{#458749}
Committed: https://chromium.googlesource.com/chromium/src/+/ba607278f124cd99822dda9cde8dfdaecef830a0

[danakj, 2017-03-21 22:15:10]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[danakj, 2017-03-21 22:15:36]

I learnt something to make less lines of code.

oshima: ash
pkasting: chrome
sadrul: ui

[commit-bot: I haz the power, 2017-03-21 22:15:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-03-21 22:16:29]

Description was changed from

==========
ui: Use SkCanvas::SkCanvas(SkBitmap) instead of going thru SkSurface

I learnt that you can just wrap an SkBitmap with an SkCanvas for cases
like these. SkSurface is a more general thing when your backing may
not be in cpu memory or when you have more complicated SkImageInfo.
For us, it is coming from the SkBitmap which is cpu memory-backed. So
this is simpler code.

R=oshima@chromium.org, pkasting@chromium.org, sadrul@chromium.org
BUG=671433
==========

to

==========
Use SkCanvas::SkCanvas(SkBitmap) instead of going thru SkSurface

I learnt that you can just wrap an SkBitmap with an SkCanvas for cases
like these. SkSurface is a more general thing when your backing may
not be in cpu memory or when you have more complicated SkImageInfo.
For us, it is coming from the SkBitmap which is cpu memory-backed. So
this is simpler code.

R=oshima@chromium.org, pkasting@chromium.org, sadrul@chromium.org
BUG=671433
==========

[Peter Kasting, 2017-03-21 22:36:22]

LGTM

[commit-bot: I haz the power, 2017-03-21 23:08:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 23:08:47]

Dry run: This issue passed the CQ dry run.

[oshima, 2017-03-21 23:42:06]

ash lgtm

[sadrul, 2017-03-22 14:50:14]

lgtm

[danakj, 2017-03-22 14:51:56]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2017-03-22 14:52:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 14:56:11]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490194316550050, "parent_rev":
"a57f7423203a181f96f9558bb51d7346e809935d", "commit_rev":
"ba607278f124cd99822dda9cde8dfdaecef830a0"}

[commit-bot: I haz the power, 2017-03-22 14:56:56]

Description was changed from

==========
Use SkCanvas::SkCanvas(SkBitmap) instead of going thru SkSurface

I learnt that you can just wrap an SkBitmap with an SkCanvas for cases
like these. SkSurface is a more general thing when your backing may
not be in cpu memory or when you have more complicated SkImageInfo.
For us, it is coming from the SkBitmap which is cpu memory-backed. So
this is simpler code.

R=oshima@chromium.org, pkasting@chromium.org, sadrul@chromium.org
BUG=671433
==========

to

==========
Use SkCanvas::SkCanvas(SkBitmap) instead of going thru SkSurface

I learnt that you can just wrap an SkBitmap with an SkCanvas for cases
like these. SkSurface is a more general thing when your backing may
not be in cpu memory or when you have more complicated SkImageInfo.
For us, it is coming from the SkBitmap which is cpu memory-backed. So
this is simpler code.

R=oshima@chromium.org, pkasting@chromium.org, sadrul@chromium.org
BUG=671433

Review-Url: https://codereview.chromium.org/2764163002
Cr-Commit-Position: refs/heads/master@{#458749}
Committed:
https://chromium.googlesource.com/chromium/src/+/ba607278f124cd99822dda9cde8d...
==========

[commit-bot: I haz the power, 2017-03-22 14:56:58]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ba607278f124cd99822dda9cde8d...