Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2764113004:
[Mac] Revert to using the public API to display notification icons (Closed)
|
Created:
3 years, 9 months ago by Miguel Garcia Modified:
3 years, 9 months ago CC:
chromium-reviews, mac-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[Mac] Revert to using the public API to display notification icons
BUG=701913
Review-Url: https://codereview.chromium.org/2764113004
Cr-Commit-Position: refs/heads/master@{#459054}
Committed: https://chromium.googlesource.com/chromium/src/+/a2f2fb7132fc8c110f22390b15e764f68dd6359a
Patch Set 1 #
Total comments: 1
Patch Set 2 : review #
Total comments: 1
Patch Set 3 : review #Messages
Total messages: 21 (13 generated)
miguelg@chromium.org changed reviewers: + rsesek@chromium.org
Will only land if agreed by UX
The CQ bit was checked by miguelg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
CL description nit: "[Mac]" not "[MAC]" (the latter is "Mandatory Access Control" or "Media Access Control" :)). https://codereview.chromium.org/2764113004/diff/1/chrome/browser/ui/cocoa/not... File chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm (right): https://codereview.chromium.org/2764113004/diff/1/chrome/browser/ui/cocoa/not... chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm:143: [toast setValue:@NO forKey:@"_identityImageHasBorder"]; Is this still necessary?
Description was changed from ========== [MAC] Revert to using the public API to display notification icons BUG=701913 ========== to ========== [Mac] Revert to using the public API to display notification icons BUG=701913 ==========
On 2017/03/22 14:36:16, Robert Sesek wrote: > CL description nit: "[Mac]" not "[MAC]" (the latter is "Mandatory Access > Control" or "Media Access Control" :)). Noted :) > > https://codereview.chromium.org/2764113004/diff/1/chrome/browser/ui/cocoa/not... > File chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm (right): > > https://codereview.chromium.org/2764113004/diff/1/chrome/browser/ui/cocoa/not... > chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm:143: [toast > setValue:@NO forKey:@"_identityImageHasBorder"]; > Is this still necessary? It's not, removed
LGTM
https://codereview.chromium.org/2764113004/diff/20001/chrome/browser/ui/cocoa... File chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm (right): https://codereview.chromium.org/2764113004/diff/20001/chrome/browser/ui/cocoa... chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm:137: [toast setValue:image forKey:@"contentImage"]; Actually, this can now be just setContentImage: right? And you can remove the redundant line out of the if block.
The CQ bit was checked by miguelg@chromium.org to run a CQ dry run
The CQ bit was unchecked by miguelg@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by miguelg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org Link to the patchset: https://codereview.chromium.org/2764113004/#ps40001 (title: "review")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
also lgtm
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490270184596820,
"parent_rev": "a124c835aadb7c241e5b2bf8c06d758bef4b93fd", "commit_rev":
"a2f2fb7132fc8c110f22390b15e764f68dd6359a"}
Message was sent while issue was closed.
Description was changed from ========== [Mac] Revert to using the public API to display notification icons BUG=701913 ========== to ========== [Mac] Revert to using the public API to display notification icons BUG=701913 Review-Url: https://codereview.chromium.org/2764113004 Cr-Commit-Position: refs/heads/master@{#459054} Committed: https://chromium.googlesource.com/chromium/src/+/a2f2fb7132fc8c110f22390b15e7... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/a2f2fb7132fc8c110f22390b15e7... |
