Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2764113003: Add 'caret-color' CSS property to _colorAwareProperties (Closed)

Created:
3 years, 9 months ago by kdzwinel
Modified:
3 years, 9 months ago
Reviewers:
chenwilliam, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Add 'caret-color' CSS property to _colorAwareProperties http://i.imgur.com/i1C0xby.png BUG=703552 Review-Url: https://codereview.chromium.org/2764113003 Cr-Commit-Position: refs/heads/master@{#458696} Committed: https://chromium.googlesource.com/chromium/src/+/f9f76a2c8a9757bfada489528fe3d0a8eb9ff374

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
kdzwinel
PTAL
3 years, 9 months ago (2017-03-21 22:18:29 UTC) #3
chenwilliam
thanks! I updated the title to match our style. lgtm (I'm not an owner so ...
3 years, 9 months ago (2017-03-21 22:43:59 UTC) #5
kdzwinel
On 2017/03/21 at 22:43:59, chenwilliam wrote: > thanks! I updated the title to match our ...
3 years, 9 months ago (2017-03-21 22:51:57 UTC) #6
chenwilliam
On 2017/03/21 22:51:57, kdzwinel wrote: > On 2017/03/21 at 22:43:59, chenwilliam wrote: > > thanks! ...
3 years, 9 months ago (2017-03-21 23:40:00 UTC) #7
pfeldman
lgtm
3 years, 9 months ago (2017-03-22 00:58:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764113003/1
3 years, 9 months ago (2017-03-22 00:58:42 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder ...
3 years, 9 months ago (2017-03-22 03:01:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764113003/1
3 years, 9 months ago (2017-03-22 09:15:16 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 09:19:00 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f9f76a2c8a9757bfada489528fe3...

Powered by Google App Engine
This is Rietveld 408576698