|
|
Chromium Code Reviews|
Created:
3 years, 9 months ago by kdzwinel Modified:
3 years, 9 months ago CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: Add 'caret-color' CSS property to _colorAwareProperties
http://i.imgur.com/i1C0xby.png
BUG=703552
Review-Url: https://codereview.chromium.org/2764113003
Cr-Commit-Position: refs/heads/master@{#458696}
Committed: https://chromium.googlesource.com/chromium/src/+/f9f76a2c8a9757bfada489528fe3d0a8eb9ff374
Patch Set 1 #
Messages
Total messages: 17 (8 generated)
Description was changed from ========== Add 'caret-color' CSS property to _colorAwareProperties BUG=703552 ========== to ========== Add 'caret-color' CSS property to _colorAwareProperties http://i.imgur.com/i1C0xby.png BUG=703552 ==========
kdzwinel@gmail.com changed reviewers: + chenwilliam@chromium.org, pfeldman@chromium.org
PTAL
Description was changed from ========== Add 'caret-color' CSS property to _colorAwareProperties http://i.imgur.com/i1C0xby.png BUG=703552 ========== to ========== DevTools: Add 'caret-color' CSS property to _colorAwareProperties http://i.imgur.com/i1C0xby.png BUG=703552 ==========
thanks! I updated the title to match our style. lgtm (I'm not an owner so will need pfeldman's stamp)
On 2017/03/21 at 22:43:59, chenwilliam wrote: > thanks! I updated the title to match our style. lgtm (I'm not an owner so will need pfeldman's stamp) oops, I forgot about the prefix. Will start using it from now on. Thanks! BTW: Contribution guide says to include you and pfeldman as reviewers by default, but I'd like to avoid annoying more people than needed with my CLs. How do I figure out who is the owner of the affected part of the code? Looking at git blame?
On 2017/03/21 22:51:57, kdzwinel wrote: > On 2017/03/21 at 22:43:59, chenwilliam wrote: > > thanks! I updated the title to match our style. lgtm (I'm not an owner so will > need pfeldman's stamp) > > oops, I forgot about the prefix. Will start using it from now on. Thanks! > > BTW: Contribution guide says to include you and pfeldman as reviewers by > default, but I'd like to avoid annoying more people than needed with my CLs. How > do I figure out who is the owner of the affected part of the code? Looking at > git blame? No worries - it's easy for me to add the right person (e.g. @allada for network-related stuff), but yeah I usually use git blame myself when I'm unsure. There is a tool "git cl owners" to select OWNERS but it's not always that helpful so I rarely use it.
The CQ bit was checked by pfeldman@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder probably lacks capacity) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder probably lacks capacity)
The CQ bit was checked by kdzwinel@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490174100515250, "parent_rev":
"fd1a23a745f72ad8116a8c6ec278022a2cc5a074", "commit_rev":
"f9f76a2c8a9757bfada489528fe3d0a8eb9ff374"}
Message was sent while issue was closed.
Description was changed from ========== DevTools: Add 'caret-color' CSS property to _colorAwareProperties http://i.imgur.com/i1C0xby.png BUG=703552 ========== to ========== DevTools: Add 'caret-color' CSS property to _colorAwareProperties http://i.imgur.com/i1C0xby.png BUG=703552 Review-Url: https://codereview.chromium.org/2764113003 Cr-Commit-Position: refs/heads/master@{#458696} Committed: https://chromium.googlesource.com/chromium/src/+/f9f76a2c8a9757bfada489528fe3... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f9f76a2c8a9757bfada489528fe3... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
