Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2764003003: Do not obfuscate hamcrest classes (Closed)

Created:
3 years, 9 months ago by the real yoland
Modified:
3 years, 9 months ago
Reviewers:
dullweber, jbudorick
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not obfuscate hamcrest classes Do not obfuscate hamcrest classes since there are matchers in hamcrest that uses reflection on its own methods, and would result in error when proguard obfuscate them BUG=702152 Review-Url: https://codereview.chromium.org/2764003003 Cr-Commit-Position: refs/heads/master@{#458660} Committed: https://chromium.googlesource.com/chromium/src/+/960eba52b467435abe56bf27078796c423754ce4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/hamcrest/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/hamcrest/proguard.flags View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
the real yoland
3 years, 9 months ago (2017-03-22 01:07:13 UTC) #2
jbudorick
lgtm
3 years, 9 months ago (2017-03-22 01:34:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764003003/1
3 years, 9 months ago (2017-03-22 02:11:18 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder ...
3 years, 9 months ago (2017-03-22 03:15:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764003003/1
3 years, 9 months ago (2017-03-22 05:26:02 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 07:19:05 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/960eba52b467435abe56bf270787...

Powered by Google App Engine
This is Rietveld 408576698