[password_manager] Add TODO to record usages of "return std::move(foo)" pattern.

[password_manager] Add TODO to record usages of "return std::move(foo)" pattern.

Due to a bug in the version of clang shipped with Xcode 8.x (used
to build official), it is required to use sub-optimal construct
"return std::move(foo)" to return local variable foo if foo is a
unique pointer of a sub-class of the function prototype. Mark all
occurrences of the pattern to easily find them once Xcode bug is
fixed.

Following https://codereview.chromium.org/2762973002/ for iOS, this CL marks
the workaround patter in password manager code.

BUG=703565
R=sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2763973002
Cr-Commit-Position: refs/heads/master@{#458383}
Committed: https://chromium.googlesource.com/chromium/src/+/e7744503e5d45e5404373b447e1499c981174eb9

[vabr (Chromium), 2017-03-21 10:46:20]

Hi sdefresne@,

Could you please review?

Looking at the failures which made me use std::move in
https://codereview.chromium.org/2754043002/#ps1, this was an issue on iOS,
Android and CrOS, but surprisingly not on Mac.

It could still be the issue of the particular clang version (not sure which one
is used by which platform), and it seems to do no harm to mark this for a
clean-up. If there are still platforms which fail to compile at that point, one
can just exclude this bit.

Cheers,
Vaclav

[vabr (Chromium), 2017-03-21 10:46:27]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 10:46:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-03-21 10:48:56]

lgtm

[vabr (Chromium), 2017-03-21 10:53:09]

The CQ bit was unchecked by vabr@chromium.org

[vabr (Chromium), 2017-03-21 10:53:13]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2017-03-21 10:53:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 12:49:05]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490093593850270, "parent_rev":
"38052ae353aee8c943b570b5a2c10be82a48c1ae", "commit_rev":
"e7744503e5d45e5404373b447e1499c981174eb9"}

[commit-bot: I haz the power, 2017-03-21 12:50:06]

Description was changed from

==========
[password_manager] Add TODO to record usages of "return std::move(foo)" pattern.

Due to a bug in the version of clang shipped with Xcode 8.x (used
to build official), it is required to use sub-optimal construct
"return std::move(foo)" to return local variable foo if foo is a
unique pointer of a sub-class of the function prototype. Mark all
occurrences of the pattern to easily find them once Xcode bug is
fixed.

Following https://codereview.chromium.org/2762973002/ for iOS, this CL marks
the workaround patter in password manager code.

BUG=703565
R=sdefresne@chromium.org
==========

to

==========
[password_manager] Add TODO to record usages of "return std::move(foo)" pattern.

Due to a bug in the version of clang shipped with Xcode 8.x (used
to build official), it is required to use sub-optimal construct
"return std::move(foo)" to return local variable foo if foo is a
unique pointer of a sub-class of the function prototype. Mark all
occurrences of the pattern to easily find them once Xcode bug is
fixed.

Following https://codereview.chromium.org/2762973002/ for iOS, this CL marks
the workaround patter in password manager code.

BUG=703565
R=sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2763973002
Cr-Commit-Position: refs/heads/master@{#458383}
Committed:
https://chromium.googlesource.com/chromium/src/+/e7744503e5d45e5404373b447e14...
==========

[commit-bot: I haz the power, 2017-03-21 12:50:07]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e7744503e5d45e5404373b447e14...