third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js - Issue 2763913002: Allow DOM.getNodeForLocation to skip to nearest non-shadow ancestor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js

Issue 2763913002: Allow DOM.getNodeForLocation to skip to nearest non-shadow ancestor (Closed)

Patch Set: Use Common.moduleSettings value to in/exclude UA shadow dom Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js

index b6d4378f881608d8dfd771da4ddf8d60ced25743..cbc30f90a6b3e685d7c17f7dd9469442d8594ab1 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js

@@ -1826,10 +1826,11 @@ SDK.DOMModel = class extends SDK.SDKModel {

/**

* @param {number} x

* @param {number} y

+ * @param {boolean} includeUserAgentShadowDOM

* @param {function(?SDK.DOMNode)} callback

- nodeForLocation(x, y, callback) {

- this._agent.getNodeForLocation(x, y, mycallback.bind(this));

+ nodeForLocation(x, y, includeUserAgentShadowDOM, callback) {

+ this._agent.getNodeForLocation(x, y, includeUserAgentShadowDOM, mycallback.bind(this));

/**

* @param {?Protocol.Error} error