third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js - Issue 2763913002: Allow DOM.getNodeForLocation to skip to nearest non-shadow ancestor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js

Issue 2763913002: Allow DOM.getNodeForLocation to skip to nearest non-shadow ancestor (Closed)

Patch Set: Use Common.moduleSettings value to in/exclude UA shadow dom Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/browser_protocol.json ('k') | third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js b/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js

index 95d5491fcff536e1b760797a48681c2fb787f862..1c45cbb71d43dab826e883b480500cbf7ec8dee4 100644

--- a/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js

+++ b/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js

@@ -231,7 +231,8 @@ Screencast.ScreencastView = class extends UI.VBox {

var position = this._convertIntoScreenSpace(event);

this._domModel.nodeForLocation(

Math.floor(position.x / this._pageScaleFactor + this._scrollOffsetX),

- Math.floor(position.y / this._pageScaleFactor + this._scrollOffsetY), callback.bind(this));

+ Math.floor(position.y / this._pageScaleFactor + this._scrollOffsetY),

+ Common.moduleSetting('showUAShadowDOM').get(), callback.bind(this));

peleg 2017/03/23 02:37:40 this works, but is there anywhere else we need to

pfeldman 2017/03/23 17:26:03 module dependencies are defined in module.json fil

/**

* @param {?SDK.DOMNode} node