third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h - Issue 2763913002: Allow DOM.getNodeForLocation to skip to nearest non-shadow ancestor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h

Issue 2763913002: Allow DOM.getNodeForLocation to skip to nearest non-shadow ancestor (Closed)

Patch Set: Use Common.moduleSettings value to in/exclude UA shadow dom Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h

diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h

index f5849ac29c79f392c7ecc9fbb74e84b4883d4e5d..ac155c304191e85206762ad01b44cd33dfb929c6 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h

+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h

@@ -220,7 +220,11 @@ class CORE_EXPORT InspectorDOMAgent final

protocol::Response getBoxModel(

int nodeId,

std::unique_ptr<protocol::DOM::BoxModel>*) override;

- protocol::Response getNodeForLocation(int x, int y, int* outNodeId) override;

+ protocol::Response getNodeForLocation(

+ int x,

+ int y,

+ protocol::Maybe<bool> includeUserAgentShadowDOM,

+ int* outNodeId) override;

protocol::Response getRelayoutBoundary(int nodeId, int* outNodeId) override;

protocol::Response getHighlightObjectForTest(

int nodeId,