Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1277)

Unified Diff: third_party/WebKit/Source/web/TextFinder.cpp

Issue 2763893002: [WIP] Clean up DocumentMarkerController API (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/TextFinder.cpp
diff --git a/third_party/WebKit/Source/web/TextFinder.cpp b/third_party/WebKit/Source/web/TextFinder.cpp
index 7fd1db6032c3ba42c1a40bff96e934d7b7e55391..b2ab7d98852819bf515feb76e1018ae938d51475 100644
--- a/third_party/WebKit/Source/web/TextFinder.cpp
+++ b/third_party/WebKit/Source/web/TextFinder.cpp
@@ -397,7 +397,8 @@ void TextFinder::scopeStringMatches(int identifier,
}
ownerFrame().frame()->document()->markers().addTextMatchMarker(
- EphemeralRange(resultRange), foundActiveMatch);
+ resultRange->startPosition(), resultRange->endPosition(),
+ foundActiveMatch);
m_findMatchesCache.push_back(
FindMatch(resultRange, m_lastMatchCount + matchCount));
@@ -694,7 +695,7 @@ TextFinder::~TextFinder() {}
bool TextFinder::setMarkerActive(Range* range, bool active) {
if (!range || range->collapsed())
return false;
- return ownerFrame().frame()->document()->markers().setMarkersActive(
+ return ownerFrame().frame()->document()->markers().setTextMatchMarkersActive(
EphemeralRange(range), active);
}

Powered by Google App Engine
This is Rietveld 408576698