[WIP] Clean up DocumentMarkerController API

Clean up DocumentMarker/DocumentMarkerController API


DMC refactor part 2

Follow-up to the first part of the refactor in
https://codereview.chromium.org/2723663002

- Rename some DocumentMarkerController methods to reflect that they only apply
  to TextMatch markers

- Remove MarkerRemoverPredicate, now the method for removing spelling markers based on a list of words just takes a list of words

BUG=707867

[rlanday, 2017-03-21 02:05:34]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[rlanday, 2017-03-21 02:05:56]

rlanday@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yosin@chromium.org

[rlanday, 2017-03-21 02:05:56]

rlanday@chromium.org changed required reviewers:
+ yosin@chromium.org

[commit-bot: I haz the power, 2017-03-21 02:06:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 03:31:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 03:31:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yosin_UTC9, 2017-03-21 05:46:55]

https://codereview.chromium.org/2763893002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h
(right):

https://codereview.chromium.org/2763893002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h:67:
void addGrammarMarker(const Position& start,
Could you introduce them one-by-one to make patch smaller?

https://codereview.chromium.org/2763893002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h:73:
void addTextMatchMarker(const Position& start,
We prefer to use |EPhemeralRange| instead of passing two |Positions|.
Please keep |addTextMatchMarker()| as is.

Note: We don't need to make to use |addSpellingMarker()| to |addGrammarMakrer()|
to use |EphemeralRange| when introducing them.
It should be yet another patch of introducing them to make each patch smaller.

[rlanday, 2017-03-21 22:15:41]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[rlanday, 2017-03-21 22:16:04]

rlanday@chromium.org changed reviewers:
+ tkent@chromium.org

[rlanday, 2017-03-21 22:16:04]

rlanday@chromium.org changed required reviewers:
+ tkent@chromium.org

[commit-bot: I haz the power, 2017-03-21 22:16:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rlanday, 2017-03-21 22:16:56]

On 2017/03/21 at 05:46:55, yosin wrote:
>
https://codereview.chromium.org/2763893002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h
(right):
> 
>
https://codereview.chromium.org/2763893002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h:67:
void addGrammarMarker(const Position& start,
> Could you introduce them one-by-one to make patch smaller?
> 
>
https://codereview.chromium.org/2763893002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h:73:
void addTextMatchMarker(const Position& start,
> We prefer to use |EPhemeralRange| instead of passing two |Positions|.
> Please keep |addTextMatchMarker()| as is.
> 
> Note: We don't need to make to use |addSpellingMarker()| to
|addGrammarMakrer()| to use |EphemeralRange| when introducing them.
> It should be yet another patch of introducing them to make each patch smaller.

Ok, I've removed all the addMarker/create*Marker changes, I will upload them in
separate CLs

[rlanday, 2017-03-21 22:17:37]

Description was changed from

==========
Clean up DocumentMarker/DocumentMarkerController API


DMC refactor part 2

Follow-up to the first part of the refactor in
https://codereview.chromium.org/2723663002

This mainly consists of two sets of changes:

- Renaming some DocumentMarkerController methods to reflect that they only apply
  to TextMatch markers

- Replacing the public DocumentMarker constructors with one create method for
  each MarkerType, and also making the methods in DocumentMarkerController for
  adding a marker each specific to a MarkerType. The current set of constructors
  + methods is messy and lets you construct a DocumentMarker without specifying
  all the information that its MarkerType needs (in which case you currently end
  up with some defaults which may or may not be what you intended).

BUG=
==========

to

==========
Clean up DocumentMarker/DocumentMarkerController API


DMC refactor part 2

Follow-up to the first part of the refactor in
https://codereview.chromium.org/2723663002

- Rename some DocumentMarkerController methods to reflect that they only apply
  to TextMatch markers

- Remove MarkerRemoverPredicate, now the method for removing spelling markers
based on a list of words just takes a list of words

BUG=
==========

[commit-bot: I haz the power, 2017-03-21 22:36:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 22:36:37]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rlanday, 2017-03-22 01:03:15]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 01:03:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 03:06:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 03:06:19]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't
started yet, builder probably lacks capacity)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT,
build hasn't started yet, builder probably lacks capacity)

[yosin_UTC9, 2017-03-22 05:21:39]

On 2017/03/21 at 22:16:56, rlanday wrote:
> On 2017/03/21 at 05:46:55, yosin wrote:
> >
https://codereview.chromium.org/2763893002/diff/1/third_party/WebKit/Source/c...
> > File
third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h
(right):
> > 
> >
https://codereview.chromium.org/2763893002/diff/1/third_party/WebKit/Source/c...
> >
third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h:67:
void addGrammarMarker(const Position& start,
> > Could you introduce them one-by-one to make patch smaller?
> > 
> >
https://codereview.chromium.org/2763893002/diff/1/third_party/WebKit/Source/c...
> >
third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h:73:
void addTextMatchMarker(const Position& start,
> > We prefer to use |EPhemeralRange| instead of passing two |Positions|.
> > Please keep |addTextMatchMarker()| as is.
> > 
> > Note: We don't need to make to use |addSpellingMarker()| to
|addGrammarMakrer()| to use |EphemeralRange| when introducing them.
> > It should be yet another patch of introducing them to make each patch
smaller.
> 
> Ok, I've removed all the addMarker/create*Marker changes, I will upload them
in separate CLs

Thanks! Please make each CL small and independent each other.

[rlanday, 2017-03-22 18:23:39]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 18:24:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 19:00:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 19:00:41]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[rlanday, 2017-03-22 19:42:20]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 19:43:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 21:33:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 21:33:59]

Dry run: This issue passed the CQ dry run.

[rlanday, 2017-03-30 20:53:56]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 20:55:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 21:04:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 21:04:48]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[rlanday, 2017-04-03 17:59:36]

Patch 8 doesn't actually have any changes, I meant to update a different CL...

[rlanday, 2017-04-03 18:00:10]

On 2017/04/03 at 17:59:36, rlanday wrote:
> Patch 8 doesn't actually have any changes, I meant to update a different CL...

Sorry, meant Patch 9

[Xiaocheng, 2017-04-03 18:41:21]

lgtm.

Btw, this patch doesn't look really dependent on the other patches.

[rlanday, 2017-04-03 18:55:11]

Description was changed from

==========
Clean up DocumentMarker/DocumentMarkerController API


DMC refactor part 2

Follow-up to the first part of the refactor in
https://codereview.chromium.org/2723663002

- Rename some DocumentMarkerController methods to reflect that they only apply
  to TextMatch markers

- Remove MarkerRemoverPredicate, now the method for removing spelling markers
based on a list of words just takes a list of words

BUG=
==========

to

==========
Clean up DocumentMarker/DocumentMarkerController API


DMC refactor part 2

Follow-up to the first part of the refactor in
https://codereview.chromium.org/2723663002

- Rename some DocumentMarkerController methods to reflect that they only apply
  to TextMatch markers

- Remove MarkerRemoverPredicate, now the method for removing spelling markers
based on a list of words just takes a list of words

BUG=707867
==========

[tkent, 2017-04-04 01:54:05]

lgtm