Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2763883003: [Home] Use a taller progress bar (Closed)

Created:
3 years, 9 months ago by mdjones
Modified:
3 years, 9 months ago
Reviewers:
gone
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Home] Use a taller progress bar In Chrome Home, the progress bar is at the top of the screen. The previous 2dp height is not visible enough in this case. This change doubles the progress bar height to 4dp when Chrome Home is enabled and disabled theme colors since it is no longer part of the toolbar. BUG=703413 Review-Url: https://codereview.chromium.org/2763883003 Cr-Commit-Position: refs/heads/master@{#458516} Committed: https://chromium.googlesource.com/chromium/src/+/171e8dafe1a4e3e14f81fada3a358e4977e87627

Patch Set 1 #

Patch Set 2 : remove unused code #

Patch Set 3 : fix indeterminate init #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -27 lines) Patch
M chrome/android/java/res/values/dimens.xml View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java View 1 2 chunks +17 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/ClipDrawableProgressBar.java View 3 chunks +4 lines, -21 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java View 1 2 4 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mdjones
ptal
3 years, 9 months ago (2017-03-21 04:21:38 UTC) #2
gone
lgtm
3 years, 9 months ago (2017-03-21 18:10:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763883003/40001
3 years, 9 months ago (2017-03-21 18:38:43 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 19:43:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/171e8dafe1a4e3e14f81fada3a35...

Powered by Google App Engine
This is Rietveld 408576698