Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1732)

Unified Diff: net/android/cellular_signal_strength_unittest.cc

Issue 2763853002: Use Android callback API to obtain cellular signal strength (Closed)
Patch Set: ps Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/android/cellular_signal_strength_unittest.cc
diff --git a/net/android/cellular_signal_strength_unittest.cc b/net/android/cellular_signal_strength_unittest.cc
index c6f879723e54870ddfe70ed3d353d568463d1178..181dea125cf8cf349914bc6363f4faa2b94b3e47 100644
--- a/net/android/cellular_signal_strength_unittest.cc
+++ b/net/android/cellular_signal_strength_unittest.cc
@@ -13,30 +13,12 @@ namespace net {
namespace {
-TEST(CellularSignalStrengthAndroidTest, SignalStrengthTest) {
- int signal_strength_dbm = INT32_MIN;
- bool signal_strength_available =
- android::cellular_signal_strength::GetSignalStrengthDbm(
- &signal_strength_dbm);
-
- // Signal strength is unavailable if the device does not have an active
- // cellular connection.
- if (!NetworkChangeNotifier::IsConnectionCellular(
- NetworkChangeNotifier::GetConnectionType())) {
- return;
- }
-
- EXPECT_TRUE(signal_strength_available);
- // Signal strength (in dbM) should typically be between -130 and 0.
- EXPECT_LE(-130, signal_strength_dbm);
- EXPECT_GE(0, signal_strength_dbm);
-}
-
TEST(CellularSignalStrengthAndroidTest, SignalStrengthLevelTest) {
int signal_strength_level = INT32_MIN;
+ android::CellularSignalStrength cellular_signal_strength;
+
bool signal_strength_level_available =
- android::cellular_signal_strength::GetSignalStrengthLevel(
- &signal_strength_level);
+ cellular_signal_strength.GetSignalStrengthLevel(&signal_strength_level);
// Signal strength is unavailable if the device does not have an active
// cellular connection.

Powered by Google App Engine
This is Rietveld 408576698