Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Side by Side Diff: net/android/cellular_signal_strength_unittest.cc

Issue 2763853002: Use Android callback API to obtain cellular signal strength (Closed)
Patch Set: ps Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/android/cellular_signal_strength.h" 5 #include "net/android/cellular_signal_strength.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include "net/base/network_change_notifier.h" 9 #include "net/base/network_change_notifier.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
11 11
12 namespace net { 12 namespace net {
13 13
14 namespace { 14 namespace {
15 15
16 TEST(CellularSignalStrengthAndroidTest, SignalStrengthTest) { 16 TEST(CellularSignalStrengthAndroidTest, SignalStrengthLevelTest) {
17 int signal_strength_dbm = INT32_MIN; 17 int signal_strength_level = INT32_MIN;
18 bool signal_strength_available = 18 android::CellularSignalStrength cellular_signal_strength;
19 android::cellular_signal_strength::GetSignalStrengthDbm( 19
20 &signal_strength_dbm); 20 bool signal_strength_level_available =
21 cellular_signal_strength.GetSignalStrengthLevel(&signal_strength_level);
21 22
22 // Signal strength is unavailable if the device does not have an active 23 // Signal strength is unavailable if the device does not have an active
23 // cellular connection. 24 // cellular connection.
24 if (!NetworkChangeNotifier::IsConnectionCellular(
25 NetworkChangeNotifier::GetConnectionType())) {
26 return;
27 }
28
29 EXPECT_TRUE(signal_strength_available);
30 // Signal strength (in dbM) should typically be between -130 and 0.
31 EXPECT_LE(-130, signal_strength_dbm);
32 EXPECT_GE(0, signal_strength_dbm);
33 }
34
35 TEST(CellularSignalStrengthAndroidTest, SignalStrengthLevelTest) {
36 int signal_strength_level = INT32_MIN;
37 bool signal_strength_level_available =
38 android::cellular_signal_strength::GetSignalStrengthLevel(
39 &signal_strength_level);
40
41 // Signal strength is unavailable if the device does not have an active
42 // cellular connection.
43 if (!NetworkChangeNotifier::IsConnectionCellular( 25 if (!NetworkChangeNotifier::IsConnectionCellular(
44 NetworkChangeNotifier::GetConnectionType())) { 26 NetworkChangeNotifier::GetConnectionType())) {
45 return; 27 return;
46 } 28 }
47 29
48 EXPECT_TRUE(signal_strength_level_available); 30 EXPECT_TRUE(signal_strength_level_available);
49 EXPECT_LE(0, signal_strength_level); 31 EXPECT_LE(0, signal_strength_level);
50 EXPECT_GE(4, signal_strength_level); 32 EXPECT_GE(4, signal_strength_level);
51 } 33 }
52 34
53 } // namespace 35 } // namespace
54 36
55 } // namespace net 37 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698