Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1192)

Issue 2763843003: Merge FakeBindState{1,2} to one (Closed)

Created:
3 years, 9 months ago by tzik
Modified:
3 years, 9 months ago
Reviewers:
dcheng
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge FakeBindState{1,2} to one CallbackTest two classes in it, but there's no reason to have two similar classes. Review-Url: https://codereview.chromium.org/2763843003 Cr-Commit-Position: refs/heads/master@{#458619} Committed: https://chromium.googlesource.com/chromium/src/+/b6970e5898b37f4ba918be767004392b5b56ae36

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -19 lines) Patch
M base/callback_unittest.cc View 3 chunks +6 lines, -19 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
tzik
PTAL
3 years, 9 months ago (2017-03-21 13:55:46 UTC) #7
dcheng
lgtm
3 years, 9 months ago (2017-03-22 00:04:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763843003/1
3 years, 9 months ago (2017-03-22 01:47:50 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 02:01:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b6970e5898b37f4ba918be767004...

Powered by Google App Engine
This is Rietveld 408576698